cannot pass arguments to EDITOR command

Bug #610154 reported by Scott Moser
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
editmoin
Fix Released
Undecided
Gustavo Niemeyer
editmoin (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

Binary package hint: editmoin

per "http://niemeyer.net/editmoin":
| Hint: to use gvim as your editor, make sure you use the -f flag.

However:

$ EDITOR='gvim -f' editmoin https://a.wiki.com/smfoo
error: [Errno 2] No such file or directory

editmoin invokes EDITOR with:
| editor = os.environ.get("EDITOR", "vi")
| subprocess.call([editor, filename])

because that doesn't pass through sh, the command "gvim -f" is what is attempted to execute.

Note, this can easily be worked around with a wrapper program:
  $ cat mygvim
  #!/bin/sh
  exec gvim -f "$1"
  $ EDITOR=mygvim editmoin https://a.wiki.com/smfoo

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: editmoin 1.15-1
ProcVersionSignature: Ubuntu 2.6.35-10.15-generic 2.6.35-rc5
Uname: Linux 2.6.35-10-generic x86_64
Architecture: amd64
Date: Mon Jul 26 13:15:55 2010
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta amd64 (20100318)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: editmoin

Related branches

Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

That's fixed in 1.16, thanks to your patch.

Changed in editmoin:
assignee: nobody → Gustavo Niemeyer (niemeyer)
status: New → Fix Released
Changed in editmoin (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.