ecryptfs-setup-private should validate that the login password is correct

[Dustin Kirkland ]

Binary package hint: ecryptfs-utils

ecryptfs-setup-private should validate that the login password is correct.

Bug #259631 sort of exposed this bug. Somewhere buried in there, we have a user who enters the wrong login password. If they enter the same wrong password twice, ecryptfs-setup-private proceeds to use it.

This can be fixed with unix_chkpwd.

:-Dustin

[Dustin Kirkland  (kirkland)]

The patch to solve this looks something like this, for these two utilities.

The rest of the ecryptfs-* utilities should be fixed as well, in one fail swoop.

:-Dustin

[Dustin Kirkland  (kirkland)]

Attached debdiff solves this bug, as well as bug #287908.

Requesting sponsorship prior to Intrepid GA.

:-Dustin

[Dustin Kirkland  (kirkland)]

Updated debdiff.

:-Dustin

[Dustin Kirkland  (kirkland)]

Updated debdiff.

:-Dustin

[Dustin Kirkland  (kirkland)]

Updated debdiff. Thoroughly tested:

 * ecryptfs-add-passphrase:
 - tested with no and bad parameters, still shows usage statement
  - regression tested with command line parameters, and using stdin
  - verified that passphrase makes it into the keyring
   . check with "keyctl show"
   . clear with "keyctl clear @u")
 - tested adding arbitrary trailing new line characters and no newline character
   . verifying fgets() is working as expected

 * ecryptfs-wrap-passphrase:
  - tested with no and bad parameters, still shows usage statement
  - regression tested with command line parameters, and using stdin
  - verify that the passphrase get's encrypted
   . cat encrypted file
  - verify that the passphrase can be decrypted with the encryption passphrase
   . ecryptfs-unwrap-passphrase

 * ecryptfs-setup-private
 - tested with good and bad passphrases
 - tested on the command line, and interactively
 - unwrapped the passphrases written by ecryptfs-setup-private
 - mounted/unmounted
 - logged out, mounted/unmounted
 - rebooted, mounted/unmounted

:-Dustin

[Launchpad Janitor (janitor)]

This bug was fixed in the package ecryptfs-utils - 53-1ubuntu11

---------------
ecryptfs-utils (53-1ubuntu11) intrepid; urgency=low

  * debian/patches/55_check_password_and_remove_from_proc.dpatch:
    Fix ecryptfs-add-passphrase and ecryptfs-wrap-passphrase to take
    passphrases on standard, to protect from disclosure on the process
    table; fix callers in ecryptfs-setup-private (LP: #287908).
    Validate that the user password is correct with unix_chkpwd (LP: #287906).
  * debian/patches/00list: updated accordingly

 -- Dustin Kirkland <email address hidden> Thu, 23 Oct 2008 12:53:30 -0500