pahole: FAILED unresolved symbol cubictcp_state with linux 5.13

Bug #1928244 reported by Andrea Righi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dwarves-dfsg (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

The new linux-unstable 5.13 build is failing during the BTFIDS stage with the following errors on all architectures (except for amd64):

FAILED unresolved symbol cubictcp_state
make: *** [Makefile:1191: vmlinux] Error 255
make: *** Deleting file 'vmlinux'

There was an upstream discussion about this and the conclusion was to remove the ftrace filter and all its related functions in pahole:
https://lore.kernel.org/bpf/YI%2FLgjLxo9VCN%2Fd+@krava/

[Fix]

Apply this patch that removes the ftrace filter: https://<email address hidden>/

[Test case]

Build linux 5.13 with CONFIG_BPF_JIT and CONFIG_BTF enabled.

[Where problems could occur]

This change could potentially break users of pahole that are relying on the ftrace filter feature.

Revision history for this message
Andrea Righi (arighi) wrote :

Debdiff reported in attach seems to fix the problem (no build errors with linux-unstable 5.13).

tags: added: patch
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

$ dput ubuntu dwarves-dfsg_1.20-1ubuntu1_source.changes
Checking signature on .changes
gpg: /tmp/dwarves-dfsg_1.20-1ubuntu1_source.changes: Valid signature from 9B8EC849D5EF70ED
Checking signature on .dsc
gpg: /tmp/dwarves-dfsg_1.20-1ubuntu1.dsc: Valid signature from 9B8EC849D5EF70ED
Uploading to ubuntu (via sftp to upload.ubuntu.com):
  Uploading dwarves-dfsg_1.20-1ubuntu1.dsc: done.
  Uploading dwarves-dfsg_1.20-1ubuntu1.debian.tar.xz: done.
  Uploading dwarves-dfsg_1.20-1ubuntu1_source.buildinfo: done.
  Uploading dwarves-dfsg_1.20-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Changed in dwarves-dfsg (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dwarves-dfsg - 1.20-1ubuntu1

---------------
dwarves-dfsg (1.20-1ubuntu1) impish; urgency=medium

  * pahole: remove the ftrace filter and its related functions to prevent
    build errors with linux 5.13 (LP: #1928244)

 -- Andrea Righi <email address hidden> Wed, 12 May 2021 18:00:27 +0200

Changed in dwarves-dfsg (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted dwarves-dfsg into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dwarves-dfsg/1.21-0ubuntu1~18.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in dwarves-dfsg (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Verified in https://bugs.launchpad.net/ubuntu/+source/dwarves-dfsg/+bug/1912811 this bug was referenced in the backport changelog.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (10.5 KiB)

This bug was fixed in the package dwarves-dfsg - 1.21-0ubuntu1~18.04

---------------
dwarves-dfsg (1.21-0ubuntu1~18.04) bionic; urgency=medium

  * Backport new dwarves-dfsg to stable series without upgrading libbpf
    system-wide (LP: #1912811):
    + Update lib/bpf to libbpf_0.4.0-1ubuntu1.
    + Disable lto, since it is disabled in libbpf.
    + Build with embedded libbpf.
    + Drop libbpf-dev build dependency.
    + Lower debhelper-compat to 11.
    + Cherrypick patch from 1.22 that fixes FTBFS with old elfutils

dwarves-dfsg (1.21-0ubuntu1) impish; urgency=medium

  * New upstream release. Remaining changes:
    - pahole: cherry-pick removal of the ftrace filter and its related
    functions to prevent build errors with linux 5.13.
    - build with libbpf 0.4, as will be required in the next release.

dwarves-dfsg (1.20-1ubuntu1) impish; urgency=medium

  * pahole: remove the ftrace filter and its related functions to prevent
    build errors with linux 5.13 (LP: #1928244)

dwarves-dfsg (1.20-1) unstable; urgency=medium

  * New upstream release.
    Changes since 1.19:

    BTF encoder:
      - Improve ELF error reporting using elf_errmsg(elf_errno()).
      - Improve objcopy error handling.
      - Fix handling of 'restrict' qualifier, that was being treated
        as a 'const'.
      - Support SHN_XINDEX in st_shndx symbol indexes, to handle ELF
        objects with more than 65534 sections, for instance, which
        happens with kernels built with 'KCFLAGS="-ffunction-sections
        -fdata-sections", Other cases may include when using FG-ASLR, LTO.
      - Cope with functions without a name, as seen sometimes when
        building kernel images with some versions of clang, when a
        SEGFAULT was taking place.
      - Fix BTF variable generation for kernel modules, not skipping
        variables at offset zero.
      - Fix address size to match what is in the ELF file being
        processed, to fix using a 64-bit pahole binary to generate BTF
        for a 32-bit vmlinux image.
      - Use kernel module ftrace addresses when finding which functions
        to encode, which increases the number of functions encoded.
    DWARF loader:
      - Support DW_AT_data_bit_offset
      - DW_FORM_implicit_const in attr_numeric() and attr_offset()
      - Support DW_TAG_GNU_call_site, its the standardized rename of
        the previously supported DW_TAG_GNU_call_site.
    build:
        - Fix compilation on 32-bit architectures.

  * Refresh patches.
  * Remove ctfdwdiff and README.cross so to reuse upstream tarball as-is.
  * Update Standards-Version to 4.5.1
  * Update debhelper compatibility to 13:
    - install missing binaries: btfdiff and fullcircle
  * Add upstream metadata file
  * gbp: set upstream tarball compression to xz
  * Add lintian override for orig-tarball-missing-upstream-signature,
    see #882694.

dwarves-dfsg (1.19-1) unstable; urgency=high

  * New upstream release. Closes: #978691.
    Changes since 1.18:
    - Support split BTF, where a main BTF file, vmlinux, can be used
      to find types and then a kernel module, for instance, can have
      just what is unique to it
    - Update libbpf to get the spli...

Changed in dwarves-dfsg (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Update Released

The verification of the Stable Release Update for dwarves-dfsg has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.