dvdunauthor gets all buttons wrong (auto_action_mode)

Bug #133562 reported by John McPherson on 2007-08-19
2
Affects Status Importance Assigned to Milestone
dvdauthor (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: dvdauthor

Package: dvdauthor
Version: 0.6.14

dvdunauthor only writes out the button coordinates if the auto_action_mode is true. But this is the opposite behaviour of all the other programs - eg spuunmux crashes trying to parse the .vobs made by dvdunauthor because if auto_action_mode on a button is false then spuunmux tries to read the missing colour/coordinates/up/down/left/right settings (line 1072). Similar with subgen.c:556 and dvdvob.c:956.

Simple fix:
--- src/dvdunauthor.c-orig 2006-06-01 16:03:24.000000000 +1200
+++ src/dvdunauthor.c 2007-05-02 21:29:33.000000000 +1200
@@ -790,7 +790,7 @@
         wdstr(nm1);
         wdshort(0);
         wdbyte(b->auto_action_mode);
- if( b->auto_action_mode != 0 ) {
+ if( b->auto_action_mode == 0 ) {
             wdbyte(b->btn_coln);
             wdshort(b->x_start);
             wdshort(b->y_start);

Daniel T Chen (crimsun) on 2008-10-18
Changed in dvdauthor:
importance: Undecided → Low
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers