uid and guid setting adversely affects integrity
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Duplicity |
Fix Released
|
Medium
|
Unassigned | ||
duplicity (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: duplicity
Ubuntu 10.10 Server
Duplicity 0.6.11(compiled, not apt-get)
I have an Ubuntu machine importing nfs shares from my various systems, including those exported from Windows machines (via Cygwin). I backup all my computers from this system; it makes maintenance easy, and duplicity is a fantastic solution. Unfortunately there is a segment of code which modifies the uid and gid (in tarfile.
I attached a patch that solves the problem by extending the gid and uid fieldsize.
Related branches
- duplicity-team: Pending requested
-
Diff: 4277 lines (+2257/-1404)13 files modifiedduplicity/diffdir.py (+10/-12)
duplicity/dup_temp.py (+12/-0)
duplicity/gpg.py (+14/-0)
duplicity/patchdir.py (+10/-9)
duplicity/path.py (+8/-8)
duplicity/tarfile.py (+2154/-1271)
duplicity/util.py (+27/-0)
rdiffdir (+0/-1)
tarfile-CHANGES (+3/-0)
tarfile-LICENSE (+1/-1)
testing/diffdirtest.py (+4/-2)
testing/patchdirtest.py (+10/-17)
testing/test_tarfile.py (+4/-83)
Changed in duplicity: | |
assignee: | nobody → Kenneth Loafman (kenneth-loafman) |
importance: | Undecided → Medium |
milestone: | none → 0.6.16 |
status: | New → In Progress |
Changed in duplicity: | |
assignee: | Kenneth Loafman (kenneth-loafman) → nobody |
status: | In Progress → Fix Committed |
Changed in duplicity: | |
status: | Fix Committed → Fix Released |
How easy is it for you to try a branch of duplicity? I've linked this bug to lp:~mterry/duplicity/tarfile which uses a more up-to-date tarfile.py that seems to support negative uid/gid numbers.