msgsnarf crash on MSN data

[Rusty Shackleford]

Binary package hint: dsniff

If you'll google around somewhat, you'll find a lot of people out on the interweb complaining about msgsnarf (part of the dsniff package) getting a segfault when processing MSN data sometimes.

I've discovered that this problem can be fixed by adding a line of code to sniff_msgs in msgsnarf.c.

The fix goes a few lines before SLIST_INSERT_HEAD. You see the malloc for the "c" struct? Immediately after the malloc, but before setting the ip and nick, add:

memset(c, 0, sizeof(*c));

This will cause the structure to be zeroed out correctly and you won't get the crashes any more.

You should be able to create a patch fairly easily for this and fix the bug.

-SG