Please default to nocheck on riscv64

[Balint Reczey]

The builders use more cores than on other architectures to speed up builds but running riscv64 tests are still very slow in the current emulated enviromnent and they can also be flaky blocking packages from migration via the missing builds.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dpkg - 1.20.5ubuntu2

---------------
dpkg (1.20.5ubuntu2) groovy; urgency=medium

  * scripts/Dpkg/Vendor/Ubuntu.pm: set 'nocheck' in build options by default
    on Ubuntu/riscv64. Overridable in debian/rules with
    'DEB_BUILD_OPTIONS := $(filter-out nocheck,$(DEB_BUILD_OPTIONS))'.
    LP: #1891686.

 -- Steve Langasek <email address hidden> Mon, 31 Aug 2020 00:34:46 +0000

[Balint Reczey (rbalint)]

The original fix does not work for packages using old-style debhelper, such as glibc and strace 5.5-3ubuntu1.

This fix exports build opts only once thus avoids overriding the previous export.

[Steve Langasek (vorlon)]

Balint, have you tested that this works correctly for the case that DEB_BUILD_OPTS has been set by the maintainer?

[Balint Reczey (rbalint)]

No, testing it.

[Balint Reczey (rbalint)]

Yes, it seems so:

https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3801/+build/20224294
https://launchpadlibrarian.net/504408668/google-guest-agent_20200617.00-0ubuntu5_20200617.00-0ubuntu6~rbalinttest1.diff.gz

[Steve Langasek (vorlon)]

Ok, looks good. Does it also work correctly using DEB_BUILD_OPTIONS := $(filter-out nocheck,$(DEB_BUILD_OPTIONS)), as mentioned in the changelog?

[Balint Reczey (rbalint)]

Ah, sorry by DEB_BUILD_OPTS I thought you meant DEB_BUILD_OPTIONS as listed in the changelog and this is what I've tested:

--- google-guest-agent-20200617.00/debian/rules 2020-10-02 22:47:33.000000000 +0000
+++ google-guest-agent-20200617.00/debian/rules 2020-10-22 15:29:37.000000000 +0000
@@ -1,5 +1,8 @@
 #!/usr/bin/make -f

+# check if nocheck can be readded
+DEB_BUILD_OPTIONS := $(filter-out nocheck,$(DEB_BUILD_OPTIONS))
+
 %:

I guess we don't have to care about DEB_BUILD_OPTS:
https://lintian.debian.org/tags/debian-rules-uses-deb-build-opts.html

[Steve Langasek (vorlon)]

ok, sounds good then, please upload!