dpdk 17.11.6-0~ubuntu18.04.1 ADT test failure with linux-hwe-edge 5.3.0-19.20~18.04.2

[Khaled El Mously]

[Impact]
The DKMS package won't work with new kernels on bionic.

[Test case]
Install and load the modules.

[Regression potential]
This might break the functioning of the module.

-----------------------------------

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/d/dpdk/20191023_185600_2c3fe@/log.gz
    arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/arm64/d/dpdk/20191023_192000_2c3fe@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/i386/d/dpdk/20191023_185942_2c3fe@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/ppc64el/d/dpdk/20191023_190318_2c3fe@/log.gz

[Christian Ehrhardt  (paelzer)]

Using https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.3.7/ I found the error to be:
make[1]: Entering directory '/usr/src/linux-headers-5.3.7-050307-generic'
  CC [M] /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_misc.o
  CC [M] /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.o
/var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.c:40:10: fatal error: kni_fifo.h: No such file or directory
 #include <kni_fifo.h>
          ^~~~~~~~~~~~
compilation terminated.
scripts/Makefile.build:280: recipe for target '/var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.o' failed
make[2]: *** [/var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.o] Error 1
Makefile:1626: recipe for target '_module_/var/lib/dkms/dpdk-rte-kni/17.11.6/build' failed
make[1]: *** [_module_/var/lib/dkms/dpdk-rte-kni/17.11.6/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.3.7-050307-generic'
/usr/share/dpdk//mk/rte.module.mk:78: recipe for target 'rte_kni.ko' failed
make: *** [rte_kni.ko] Error 2

Note: 4.15.0-67-generic and 5.0.0-32-generic work.

[Christian Ehrhardt  (paelzer)]

There are no fixes ustream that I'd have found, but they dropped rte_kni support.
No fixes int he stable series either it seems.

[Christian Ehrhardt  (paelzer)]

This is odd, as the including file and the include are both from kni and they are there:

root@b:~/5.3# vim /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.c
root@b:~/5.3# vim /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_fifo.h

This is either super trivial (paths) or weird (build system changes)

[Christian Ehrhardt  (paelzer)]

As expected it was just a path.
Submitted upstream for ack there (on the stable series).

=> http://mails.dpdk.org/archives/stable/2019-October/018040.html
=> http://mails.dpdk.org/archives/stable/2019-October/018041.html

Interesting is that I don't see any different in DPDK 18.11.x code but that works with 5.3.7-050307.201910180652 despit the kni_netc doing the same include and no diff in the makefile - might even be differences in DKMS.

Anyway - we only need a fix for 17.11.x in Ubuntu it seems.
Waiting on upstreams comment on this thou.

[Christian Ehrhardt  (paelzer)]

My changed got accepted into 17.11.7, but we need to wait until that releases for an MRE.