| 2022-10-13 19:52:41 |
Andre Nathan |
bug |
|
|
added bug |
| 2022-10-13 19:53:00 |
Andre Nathan |
summary |
Backport virtual storage panic from 2.3.18 |
Backport virtual storage panic fix from 2.3.18 |
|
| 2022-10-13 19:57:57 |
Launchpad Janitor |
dovecot (Ubuntu): status |
New |
Confirmed |
|
| 2022-10-13 20:02:00 |
marcelo |
bug |
|
|
added subscriber marcelo |
| 2022-10-14 18:29:21 |
Michał Małoszewski |
dovecot (Ubuntu): assignee |
|
Michał Małoszewski (michal-maloszewski99) |
|
| 2022-10-20 22:07:20 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~michal-maloszewski99/ubuntu/+source/dovecot/+git/dovecot/+merge/431937 |
|
| 2022-11-01 14:16:58 |
Robie Basak |
summary |
Backport virtual storage panic fix from 2.3.18 |
lmtp crashes with: Panic: file mail-user.c: line 229 (mail_user_deinit): assertion failed: ((*user)->refcount == 1) |
|
| 2022-11-01 14:17:27 |
Robie Basak |
nominated for series |
|
Ubuntu Jammy |
|
| 2022-11-01 14:17:27 |
Robie Basak |
bug task added |
|
dovecot (Ubuntu Jammy) |
|
| 2022-11-01 14:17:33 |
Robie Basak |
dovecot (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2022-11-01 14:17:38 |
Robie Basak |
dovecot (Ubuntu Jammy): status |
New |
Triaged |
|
| 2022-11-01 14:19:12 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Server |
| 2023-01-03 21:27:01 |
Bryce Harrington |
dovecot (Ubuntu Jammy): status |
Triaged |
Incomplete |
|
| 2024-01-17 13:34:02 |
Athos Ribeiro |
tags |
|
server-triage-discuss |
|
| 2024-01-17 16:31:57 |
Bryce Harrington |
tags |
server-triage-discuss |
server-todo |
|
| 2024-01-17 16:32:08 |
Bryce Harrington |
dovecot (Ubuntu): assignee |
Michał Małoszewski (michal-maloszewski99) |
|
|
| 2024-01-17 16:32:09 |
Bryce Harrington |
dovecot (Ubuntu Jammy): assignee |
|
Bryce Harrington (bryce) |
|
| 2024-02-08 04:35:23 |
Bryce Harrington |
description |
Hello
We're being hit by the following error using Jammy's version of Dovecot:
Oct 13 19:21:32 imap1 dovecot: lmtp(2572154): Panic: file mail-user.c: line 229 (mail_user_deinit): assertion failed: ((*user)->refcount == 1)
This error has been reported as fixed upstream in version 2.3.18, according to https://dovecot.org/doc/NEWS:
- virtual: If mailbox opening fails, the backend mailbox is leaked and
process crashes when client disconnects. Fixes
Panic: file mail-user.c: line 232 (mail_user_deinit):
assertion failed: ((*user)->refcount == 1)
The correction is simple:
--- a/src/plugins/virtual/virtual-storage.c
+++ b/src/plugins/virtual/virtual-storage.c
@@ -495,12 +495,12 @@ static int virtual_mailbox_open(struct mailbox *box)
ret = virtual_mailboxes_open(mbox, box->flags);
array_pop_back(&mbox->storage->open_stack);
}
+ if (ret == 0)
+ ret = index_storage_mailbox_open(box, FALSE);
if (ret < 0) {
virtual_mailbox_close_internal(mbox);
return -1;
}
- if (index_storage_mailbox_open(box, FALSE) < 0)
- return -1;
mbox->virtual_ext_id =
mail_index_ext_register(mbox->box.index, "virtual", 0,
Do you think a patch could be added to the Jammy package with that fix?
Ubuntu release: Ubuntu 22.04.1 LTS
Dovecot version: 1:2.3.16+dfsg1-3ubuntu2.1
Thanks,
Andre |
[Impact]
Dovecot crashes during the delivery process with particular mail clients, due to failure to open virtual mailboxes, which leads to a leak and a crash during service de-initialization. Emails fail to get delivered until the service is re-started.
[Test Case]
Exact steps to reproduce have not been identified, but users who encounter it can reliably detect if the issue is or is not present in their environments. We will rely on user testing for verification of the fix.
[Where Problems Could Occur]
The fix changes the opening and closing of mailboxes, so issues associated with changes of behavior with mailbox opening/closing may be of note. In particular this involves virtual mailboxes, so problems would be expected to be specific to that type of storage.
[Other Info]
[Original Report]
Hello
We're being hit by the following error using Jammy's version of Dovecot:
Oct 13 19:21:32 imap1 dovecot: lmtp(2572154): Panic: file mail-user.c: line 229 (mail_user_deinit): assertion failed: ((*user)->refcount == 1)
This error has been reported as fixed upstream in version 2.3.18, according to https://dovecot.org/doc/NEWS:
- virtual: If mailbox opening fails, the backend mailbox is leaked and
process crashes when client disconnects. Fixes
Panic: file mail-user.c: line 232 (mail_user_deinit):
assertion failed: ((*user)->refcount == 1)
The correction is simple:
--- a/src/plugins/virtual/virtual-storage.c
+++ b/src/plugins/virtual/virtual-storage.c
@@ -495,12 +495,12 @@ static int virtual_mailbox_open(struct mailbox *box)
ret = virtual_mailboxes_open(mbox, box->flags);
array_pop_back(&mbox->storage->open_stack);
}
+ if (ret == 0)
+ ret = index_storage_mailbox_open(box, FALSE);
if (ret < 0) {
virtual_mailbox_close_internal(mbox);
return -1;
}
- if (index_storage_mailbox_open(box, FALSE) < 0)
- return -1;
mbox->virtual_ext_id =
mail_index_ext_register(mbox->box.index, "virtual", 0,
Do you think a patch could be added to the Jammy package with that fix?
Ubuntu release: Ubuntu 22.04.1 LTS
Dovecot version: 1:2.3.16+dfsg1-3ubuntu2.1
Thanks,
Andre |
|
| 2024-02-14 01:56:31 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~bryce/ubuntu/+source/dovecot/+git/dovecot/+merge/460472 |
|
| 2024-02-16 19:56:18 |
Bryce Harrington |
removed subscriber Ubuntu Server |
|
|
|
| 2024-02-16 19:56:29 |
Bryce Harrington |
bug |
|
|
added subscriber Ubuntu Server |
| 2024-02-16 19:56:43 |
Bryce Harrington |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2024-02-16 20:06:31 |
Bryce Harrington |
dovecot (Ubuntu Jammy): importance |
Undecided |
Medium |
|
| 2024-02-16 20:06:31 |
Bryce Harrington |
dovecot (Ubuntu Jammy): status |
Incomplete |
In Progress |
|
| 2024-02-16 20:06:31 |
Bryce Harrington |
dovecot (Ubuntu Jammy): assignee |
Bryce Harrington (bryce) |
|
|
| 2024-02-16 20:06:39 |
Bryce Harrington |
dovecot (Ubuntu Jammy): assignee |
|
Bryce Harrington (bryce) |
|
| 2024-02-16 21:45:12 |
Ubuntu Archive Robot |
bug |
|
|
added subscriber Bryce Harrington |
| 2024-02-23 13:57:42 |
Timo Aaltonen |
dovecot (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2024-02-23 13:57:44 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
| 2024-02-23 13:57:46 |
Timo Aaltonen |
tags |
server-todo |
server-todo verification-needed verification-needed-jammy |
|
| 2024-02-28 20:02:52 |
Bryce Harrington |
tags |
server-todo verification-needed verification-needed-jammy |
verification-needed verification-needed-jammy |
|
