Fix log reopen in >=2.2.33
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dovecot (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
* The version in Bionic fails to reopen the log which is needed for log
rotation
* Fix by backporting a change from latter versions
[Test Case]
* sudo apt install mail-stack-delivery
# set log_path = /var/log/
sudo vi /etc/dovecot/
sudo systemctl restart dovecot
In another terminal:
sudo mv /var/log/
sudo doveadm log reopen
Verify that /var/log/
[Regression Potential]
* log handling code is changed, so in theory this could affect log
handling. But since only the code for sig_reopen_logs (which is broken
without the fix) is changed we should be good.
There also is a header change part of the upstream change, that could
in theory affect log handling.
[Other Info]
* n/a
----
Version 2.2 comes with lots of bugs, especially this nasty one
https:/
Would be good to bump to 2.3 for Bionic. Thanks!
Related branches
- Andreas Hasenack: Approve
- Canonical Server: Pending requested
- git-ubuntu developers: Pending requested
-
Diff: 64 lines (+41/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/lp1777008-log-Fix-log-reopening-on-SIGUSR1.patch (+33/-0)
debian/patches/series (+1/-0)
summary: |
- Bump to v2.3 due to many bugs + Fix log reopen in >=2.2.33 |
Changed in dovecot (Ubuntu): | |
status: | Incomplete → Confirmed |
Changed in dovecot (Ubuntu Bionic): | |
status: | New → Confirmed |
tags: | added: server-next |
Changed in dovecot (Ubuntu): | |
status: | Confirmed → Fix Released |
description: | updated |
Changed in dovecot (Ubuntu Bionic): | |
status: | Confirmed → Triaged |
Hi Michael,
at the time we worked on the version for Bionic 2.3 was not ready yet.
See bug 1771524 for details if you want, but the above is the TL;DR.
Due to the SRu policy [1] and 2.3 being a rather bug jump from 2.2 it is imposing too much regression to pull all of 2.3 into Bionic.
For your issue though, one could consider evaluating and backporting [2].
It needs to be evaluated if it needs more than just the change, but if so would that adress your issue?
If so lets change the title to something like "fix log reopen"
The patch seems applicable, so further if one would provide a PPA would you be willing and able to test the PPA package if it fixed the issue or exposes other log related issues?
[1]: https:/ /wiki.ubuntu. com/StableRelea seUpdates /github. com/dovecot/ core/commit/ 84703c2f19113ac 731e4638ba782fa 87e0748ba6
[2]: https:/