dovecot dep8 tests intermittently fail on armhf

[Robie Basak]

======================================================================
ERROR: test_imaps (__main__.DovecotDirectTest)
Test IMAP4S protocol.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.nF7HaP/build.sRO/dovecot-2.2.24/debian/tests/general", line 183, in test_imaps
    imap = imaplib.IMAP4_SSL('localhost')
  File "/usr/lib/python2.7/imaplib.py", line 1166, in __init__
    IMAP4.__init__(self, host, port)
  File "/usr/lib/python2.7/imaplib.py", line 173, in __init__
    self.open(host, port)
  File "/usr/lib/python2.7/imaplib.py", line 1178, in open
    self.sslobj = ssl.wrap_socket(self.sock, self.keyfile, self.certfile)
  File "/usr/lib/python2.7/ssl.py", line 933, in wrap_socket
    ciphers=ciphers)
  File "/usr/lib/python2.7/ssl.py", line 601, in __init__
    self.do_handshake()
  File "/usr/lib/python2.7/ssl.py", line 830, in do_handshake
    self._sslobj.do_handshake()
SSLEOFError: EOF occurred in violation of protocol (_ssl.c:590)

----------------------------------------------------------------------
Ran 10 tests in 201.872s

FAILED (errors=1)

More at: http://autopkgtest.ubuntu.com/packages/d/dovecot/zesty/armhf

[Christian Ehrhardt  (paelzer)]

Just to confirm the "transient" behavior I passed over current update_excuses and saw 3 passes and 2 fails this morning.

[Robie Basak (racb)]

I uploaded 1:2.2.25-1ubuntu2 earlier with a bunch of test cleanups. This may or may not fix the intermittent issue.

[Robie Basak (racb)]

We decided in #ubuntu-release today that we should skip this particular test if on armhf. Christian pointed to https://gerrit.fd.io/r/gitweb?p=deb_dpdk.git;a=blob;f=debian/tests/check-dpdk-supported-arch.sh;h=1105dc2edf4dd4f7ab7f47b715f228efbfbffcf6;hb=refs/heads/16.11.x for some sample code on how to do this.

[Stephan Bosch (stephan-rename-it)]

Is this problem relevant to upstream? What is causing this? Why is this specific to armhf?

[Robie Basak (racb)]

No, it's specific to Ubuntu. It's an integration test provided in packaging that I think has a race condition that happens to only manifest on armhf, but I haven't managed to pin it down any further. I did some cleanup the last time I touched it. It still needs further fixing and then sending up to Debian, but it's pretty tricky since the race is hard to reproduce on non-armhf.

[Christian Ehrhardt  (paelzer)]

These tests are maintained outside of the package anyway.
On the coming merge of a 2.3 version I'm going to propose to leave them just in git+ssh://git.launchpad.net/qa-regression-testing where they are maintained and used on SRU/Merge/CVE activity, but no more use them as autopkgtest.

That will avoid the issue described in this bug as these tests are semi-manual and whoever is working on SRU/Merge/CVE can sort out if these are really just flaky.

Note: I want to remove them for reoccurring issues due to the redundancy, not for this bug here - this is just a side effect.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dovecot - 1:2.2.35-2ubuntu1

---------------
dovecot (1:2.2.35-2ubuntu1) cosmic; urgency=medium

  * Merge with Debian unstable (LP: #1771816). Remaining changes:
    - Add updated autopkgtest to debian/tests/* (these tests got simplified
      and streamlined to use the packages default configuration which solves
      LP: #1638865)
  * Dropped Changes (now upstream)
    - SECURITY UPDATE: rfc822_parse_domain Information Leak Vulnerability
    - SECURITY UPDATE: TLS SNI config lookups DoS
    - SECURITY UPDATE: Memory leak that can cause crash due to memory exhaustion
  * Dropped Changes (no more needed after 18.04)
    - handle conffile removal of /etc/init/dovecot.conf (due to dropping
      upstart).
  * Dropped Changes (no more needed)
    - Drop build dependency on libstemmer-dev (universe) - this is now in main
    - Disable dovecot-lucene plugin as it had various issues and is deprecated
      in favor of solr anyway (LP 1524526) - no more failing in Cosmic.
  * Dropped Changes (mail-stack-delivery)
    It was decided to no more carry mail-stack-delivery as a package in favor
    to out-of-package solutions. It became less useful due to one of the
    biggest benefit (auto-ssl setup) being part of the base setup now.
    - Add mail-stack-delivery
      - add package in d/rules, d/control
      - add d/*mail-stack-delivery* maintainer scripts and default conf
      - d/mail-stack-delivery.preinst: Move previously installed backups and
        config files to a new package namespace.
      - d/mail-stack-delivery.README.Debian clarified use of configuration files
    - d/mail-stack-delivery.postinst: Use ssl key/cert paths now set up by
      dovecot-core; transition for such configs formerly set up by
      mail-stack-delivery to use the new default ssl config (if user had no
      conffile change or choses new defaults).
    - d/mail-stack-delivery.postinst: if moving dovecot to the new defaults on
      upgrade, also move the related postfix key/cert entries.
    - debian/99-mail-stack-delivery.conf: do not explicitly enable protocols
      as all installed are auto-included from the base config now.
    - adapt autopkgtests to match new version.
    - d/control: for the ssl transition to work we need to ensure dovecot-core
      is complete before upgrading mail-stack-delivery, so add a Pre-Depends.
    - d/mail-stack-delivery.postinst: add SSL_CERT/SSL_KEY detection to
      postconf section (was formerly initialized at the now dropped key setup)
    - d/mail-stack-delivery.postinst: fix SSL_CERT/SSL_KEY detection to only
      read non-comments from the right keywords and to strip common bad-chars
    - d/mail-stack-delivery.postinst: stop modifying mandatory tls config,
      recent upstream has sane defaults now
    - debian/99-mail-stack-delivery.conf: drop explicit ssl_cipher_list,
      recent upstream has sane defaults now
  * Added Changes:
    - carry mail-stack-delivery as empty transitional package
      (can be dropped >20.04)

dovecot (1:2.2.35-2) unstable; urgency=medium

  * [7665652] Use git-subtree to generate pigeonhole patch from git; add
    single-debian-patch to d/source/local...