drac plugin in dovecot uses wrong plugin version string

Bug #1346740 reported by Peter Howard
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Dovecot
Fix Released
Unknown
dovecot (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Upstream dovecot has gone from generating the version string from DOVECOT_VERSION to DOVECOT_ABI_VERSION. However this hasn't been updated in dovecot-drac.patch, meaning the drac plugin fails to load.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in dovecot (Ubuntu):
status: New → Confirmed
Revision history for this message
Guillaume (e1msih) wrote :

Same issue with Ubuntu 14.04 AMD64.

Revision history for this message
Pietro (pietro-z) wrote :

Same issue like Guillaume. Please set importance to high.

Revision history for this message
Robie Basak (racb) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Looks like this still affects Debian VCS master since the patch there also uses DOVECOT_VERSION: http://anonscm.debian.org/cgit/collab-maint/dovecot.git/tree/debian/patches/dovecot-drac.patch#n58

If this is true, then this needs to be verified in Debian and a bug filed there, as a fixed patch would need to be applied to both. Patches welcome.

> Same issue like Guillaume. Please set importance to high.

Sorry, I disagree. GIven that this is being reported as affecting 14.04, it has been out for 18 months now and only three users are affected according to this report, it is reasonable to assume that this affects unusual end-user configurations, so according to https://wiki.ubuntu.com/Bugs/Importance the appropriate importance is Low.

However, that doesn't stop any affected from helping. If someone provides a patch I will help get it landed.

Changed in dovecot (Ubuntu):
importance: Undecided → Low
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
I was just cleaning up several dovecot issues.
While I admit that most things adopted the new DOVECOT_ABI_VERSION still "exists".

Usually when such things are renamed the old define should be gone, build would fail and things would be spotted.
Instead I took the build of the plugin and modified it to stop after preprocessor:
cc -Wall -W -shared -fPIC -DHAVE_CONFIG_H -I../../.. -I../../../src/lib -I../../../src/lib-index -I../../../src/lib-mail -I../../../src/lib-storage -I../../../src/lib-storage/index -I../../../src/lib-storage/index/maildir -I../../lib drac-plugin.c -E -o drac_plugin.E -ldrac

In the result I see it resolving to a value:
const char *drac_plugin_version = "2.2.25";

If DOVECOT_ABI_VERSION is used it would be "2.2.ABIv25(2.2.25)"

Unfortunately I have no drac setup or even an idea yet what it is in detail.
As suggested before reporting in Debian is the right way as Debian&Ubuntu use the same patch for this.

I looked into the matter 5 minutes more and I think this is just outdated, unsupported and should be dropped.
Packaged version matches latest version from https://osdn.net/projects/dovecot2-drac/
No update since 2011.
Quoting http://wiki2.dovecot.org/HowTo/PopBSMTPAndDovecot#DRAC the phrases "historical" and "no more work" together with being out of tree are not convincing at all and make me even more suggest dropping it.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Reported issue and the consideration to drop to Debian to check their opinion as well.

Changed in dovecot:
status: Unknown → New
Changed in dovecot:
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Just coming by dovecot - this was fixed in .26 and thereby is good in >=zesty

Changed in dovecot (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Not sure on the SRUs given the time this is open and the low number of reports.
Polling for opinions - is that important to be fixed back to Trusty, Xenial, Yakkety - or did the few affected already work around otherwise?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.