extensions/*.jar ship without source code, shipped jar files are installed

Bug #23184 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
docbook-xsl (Debian)
Fix Released
Unknown
docbook-xsl (Ubuntu)
Fix Released
High
Matthias Klose

Bug Description

Automatically imported from Debian bug report #331661 http://bugs.debian.org/331661

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #331661 http://bugs.debian.org/331661

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 4 Oct 2005 15:06:02 +0200
From: Matthias Klose <email address hidden>
To: <email address hidden>
Subject: extensions/*.jar ship without source code, shipped jar files are installed

Package: docbook-xsl
Version: 1.68.1
Severity: serious

The extensions contains many jar files, without having the sources in
the source package, the problematic files seem to be:

  saxon644.jar
  saxon65.jar
  saxon651.jar
  saxon652.jar
  saxon653.jar

It looks like the source for saxon643.jar and xalan25.jar is provided,
but they are not built during the build process.

Revision history for this message
In , Mark Johnson (mrj) wrote : Re: Bug#331661: extensions/*.jar ship without source code, shipped jar files are installed

Matthias Klose wrote:
> Package: docbook-xsl
> Version: 1.68.1
> Severity: serious
>
> The extensions contains many jar files, without having the sources in
> the source package, the problematic files seem to be:
>
> saxon644.jar
> saxon65.jar
> saxon651.jar
> saxon652.jar
> saxon653.jar

I don't change what comes in the upstream source package.

> It looks like the source for saxon643.jar and xalan25.jar is provided,
> but they are not built during the build process.

If docbook-xsl is now going to require a rebuild of the (supposedly)
portable jars, then we need to rethink how to package this stuff.

I'd hand it over to the java group, but they might not get the xml
catalog stuff correct - it's subtle.

Cheers,
Mark

--
____________________________________________________________
Mark Johnson <email address hidden>
Debian XML/SGML: <http://debian-xml-sgml.alioth.debian.org>
Home Page: <http://linux.duke.edu/~mark/>
GPG fp: DBEA FA3C C46A 70B5 F120 568B 89D5 4F61 C07D E242

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 04 Oct 2005 19:46:19 -0400
From: Mark Johnson <email address hidden>
To: Matthias Klose <email address hidden>, <email address hidden>
CC: <email address hidden>
Subject: Re: Bug#331661: extensions/*.jar ship without source code, shipped jar files are installed

Matthias Klose wrote:
> Package: docbook-xsl
> Version: 1.68.1
> Severity: serious
>
> The extensions contains many jar files, without having the sources in
> the source package, the problematic files seem to be:
>
> saxon644.jar
> saxon65.jar
> saxon651.jar
> saxon652.jar
> saxon653.jar

I don't change what comes in the upstream source package.

> It looks like the source for saxon643.jar and xalan25.jar is provided,
> but they are not built during the build process.

If docbook-xsl is now going to require a rebuild of the (supposedly)
portable jars, then we need to rethink how to package this stuff.

I'd hand it over to the java group, but they might not get the xml
catalog stuff correct - it's subtle.

Cheers,
Mark

--
____________________________________________________________
Mark Johnson <email address hidden>
Debian XML/SGML: <http://debian-xml-sgml.alioth.debian.org>
Home Page: <http://linux.duke.edu/~mark/>
GPG fp: DBEA FA3C C46A 70B5 F120 568B 89D5 4F61 C07D E242

Revision history for this message
In , Don Armstrong (don-debian) wrote :

On Tue, 04 Oct 2005, Mark Johnson wrote:

> Matthias Klose wrote:
> >Package: docbook-xsl
> >Version: 1.68.1
> >Severity: serious
> >
> >The extensions contains many jar files, without having the sources in
> >the source package, the problematic files seem to be:
> >
> > saxon644.jar
> > saxon65.jar
> > saxon651.jar
> > saxon652.jar
> > saxon653.jar
>
> I don't change what comes in the upstream source package.

That's fine, but the proper approach here is to either build these
files from the source code if that's available, or remove them
entirely and rebuild the orig.tar.gz as 1.68.1.dfsg.orig.tar.gz or
similar.

> >It looks like the source for saxon643.jar and xalan25.jar is provided,
> >but they are not built during the build process.
>
> If docbook-xsl is now going to require a rebuild of the (supposedly)
> portable jars, then we need to rethink how to package this stuff.

Considering the fact that you can't currently fix any bugs in those
jars, yes, that's pretty much what it means.

Regardless, for this bug there are three alternatives:

1: Ship the source code for the jars (and build the jars from it)

2: Strip out the jars and distribute as a .dfsg package

3: Remove docbox-xsl from the archive.

Please enact one of them so this bug can be resolved.

Don Armstrong

--
I never until now realized that the primary job of any emoticon is to
say "excuse me, that didn't make any sense." ;-P
 -- Cory Doctorow

http://www.donarmstrong.com http://rzlab.ucr.edu

Matt Zimmerman (mdz)
Changed in docbook-xsl:
status: Unconfirmed → Confirmed
Revision history for this message
In , Steve Langasek (vorlon) wrote :

Hello,

Don's analysis of this bug is absolutely correct; we can't ship .jar files
in main that don't have corresponding source that can be rebuilt as needed
for bugfixing; including in the source package. Is anything being done for
this bug?

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
<email address hidden> http://www.debian.org/

Revision history for this message
In , Bill Allombert (allomber) wrote :

On Fri, Mar 17, 2006 at 04:59:05PM -0800, Don Armstrong wrote:
> On Tue, 04 Oct 2005, Mark Johnson wrote:
>
> > Matthias Klose wrote:
> > >Package: docbook-xsl
> > >Version: 1.68.1
> > >Severity: serious
> > >
> > >The extensions contains many jar files, without having the sources in
> > >the source package, the problematic files seem to be:
> > >
> > > saxon644.jar
> > > saxon65.jar
> > > saxon651.jar
> > > saxon652.jar
> > > saxon653.jar
> >
> > I don't change what comes in the upstream source package.
>
> That's fine, but the proper approach here is to either build these
> files from the source code if that's available, or remove them
> entirely and rebuild the orig.tar.gz as 1.68.1.dfsg.orig.tar.gz or
> similar.
>
> > >It looks like the source for saxon643.jar and xalan25.jar is provided,
> > >but they are not built during the build process.
> >
> > If docbook-xsl is now going to require a rebuild of the (supposedly)
> > portable jars, then we need to rethink how to package this stuff.
>
> Considering the fact that you can't currently fix any bugs in those
> jars, yes, that's pretty much what it means.
>
> Regardless, for this bug there are three alternatives:
>
> 1: Ship the source code for the jars (and build the jars from it)
>
> 2: Strip out the jars and distribute as a .dfsg package
>
> 3: Remove docbox-xsl from the archive.
>
> Please enact one of them so this bug can be resolved.

Hello Mark,

docbook-xsl include the following jar files in the extensions directory:

saxon643.jar saxon651.jar saxon653.jar xalan25.jar
saxon644.jar saxon652.jar saxon65.jar

Some source code is only provided for saxon643 and xalan25.

Only saxon65.jar, saxon651.jar and xalan25.jar are currenlty shipped in
the .deb file.

The version of libsaxon-java in Debian is 6.5.5 and xalan is 2.6.0.

Given that the jar files are not essential to the packages, and given
your current level of involvement in maintaining it, I would suggest we
take the simpler route of 2. above.

This means to build a new "upstream" tarball 1.68.1.dfsg.1
(or eventually 1.69.1.dfsg.1 since docbook-xsl-1.69.1 was released)
that does not include the extensions directory, and remove reference
to theses extensions in the packaging.

For that purpose, I have made suitable packages available at
<http://people.debian.org/~ballombe/pnmu/docbook-xsl/>.
I attach the output of debdiff minus the removal of the extensions
directory.

Given that this RC bug is 6 months old, we need to fix it soon, so
I would appreciate an answer in less than a week.

Thanks in advance for your answer,
--
Bill. <email address hidden>

Imagine a large red swirl here.

Revision history for this message
In , Bill Allombert (allomber) wrote :

On Fri, Apr 21, 2006 at 03:02:10PM +0200, <email address hidden> wrote:
> On Fri, Mar 17, 2006 at 04:59:05PM -0800, Don Armstrong wrote:
> Hello Mark,
>
> docbook-xsl include the following jar files in the extensions directory:
>
> saxon643.jar saxon651.jar saxon653.jar xalan25.jar
> saxon644.jar saxon652.jar saxon65.jar
>
> Some source code is only provided for saxon643 and xalan25.
>
> Only saxon65.jar, saxon651.jar and xalan25.jar are currenlty shipped in
> the .deb file.
>
> The version of libsaxon-java in Debian is 6.5.5 and xalan is 2.6.0.
>
> Given that the jar files are not essential to the packages, and given
> your current level of involvement in maintaining it, I would suggest we
> take the simpler route of 2. above.
>
> This means to build a new "upstream" tarball 1.68.1.dfsg.1
> (or eventually 1.69.1.dfsg.1 since docbook-xsl-1.69.1 was released)
> that does not include the extensions directory, and remove reference
> to theses extensions in the packaging.
>
> For that purpose, I have made suitable packages available at
> <http://people.debian.org/~ballombe/pnmu/docbook-xsl/>.
> I attach the output of debdiff minus the removal of the extensions
> directory.
>
> Given that this RC bug is 6 months old, we need to fix it soon, so
> I would appreciate an answer in less than a week.

Hello Mark,

Unless I hear from you, I plan to upload the above packages soon now.

Cheers,
--
Bill. <email address hidden>

Imagine a large red swirl here.

Matt Zimmerman (mdz)
Changed in docbook-xsl:
assignee: nobody → doko
Revision history for this message
In , Bill Allombert (ballombe) wrote : Fixed in NMU of docbook-xsl 1.68.1.dfsg.1-0.1

tag 331661 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 4 May 2006 19:38:18 +0200
Source: docbook-xsl
Binary: docbook-xsl
Architecture: source all
Version: 1.68.1.dfsg.1-0.1
Distribution: unstable
Urgency: low
Maintainer: Mark Johnson <email address hidden>
Changed-By: Bill Allombert <email address hidden>
Description:
 docbook-xsl - stylesheets for processing DocBook XML files to various output fo
Closes: 331661
Changes:
 docbook-xsl (1.68.1.dfsg.1-0.1) unstable; urgency=low
 .
   * NMU
   * new "upstream" tarball:
     - Remove the extensions directory that contains the xalan and saxon
       JAVA extensions we are missing the source for.
       (closes: #331661).
     (Do not forget to remove them from future new upstream versions.)
   * debian/control:
     - Remove reference to these extensions in the description.
   * debian/docbook-xsl.install debian/docbook-xsl.links
     debian/docbook-xsl.dirs debian/rules:
     - do not install the removed extensions.
Files:
 613155b530c5dcf250c858f3859b1c28 620 text optional docbook-xsl_1.68.1.dfsg.1-0.1.dsc
 0cb14292dc912e07d5b1a91460cad045 1292461 text optional docbook-xsl_1.68.1.dfsg.1.orig.tar.gz
 48f92d289a9bdb14904e4f3dea66028e 6032 text optional docbook-xsl_1.68.1.dfsg.1-0.1.diff.gz
 9bb647953d31d88108a2f597995bc8f1 1102164 text optional docbook-xsl_1.68.1.dfsg.1-0.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEWmtXeDPs8bVESBURAiOJAKCVIs2EEDiDedvMcblQZEztJutcSwCfR8eM
wiN/pqWKxv0nUXHBPuFEwFg=
=KvnI
-----END PGP SIGNATURE-----

Revision history for this message
In , Daniel Leidert (dleidert-deactivatedaccount) wrote : Closing old NMUs directly

To clean the BTS I'm closing all old NMUs of docbook-xsl directly.

Closing #148510: docbook-xsl: contents of profiling directory missing
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=148510
Closing #171742: docbook-xsl: bibliography.numbered not used in xref.
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=171742
Closing #188970: xsl:apply-templates : can't find doc
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=188970
Closing #232119: 1.64.1.0-4 fails to install (stylesheet/xsl does not exist)
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=232119
Closing #232428: mkdir: cannot create directory `/usr/share/sgml/docbook/stylesheet/xsl'
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=232428
Closing #232601: docbook-xsl: missing build dependency on xml-core
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=232601
Closing #232603: docbook-xsl: make package description conform with developer's reference
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=232603
Closing #232682: docbook-xsl - failes to configure
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=232682
Closing #236924: othercredit formatting bug in xhtml
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=236924
Closing #248146: docbook-xsl: bug with output because of : $title.margin.left , bug solved in 1.65.
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=248146
Closing #263933: docbook-xsl: translation mistake in nl.xml
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=263933
Closing #280858: new upstream version
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=280858
Closing #280862: &nbsp; output incorrect for manpages
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=280862
Closing #299385: docbook-xsl: New upstream release 1.68.1 that corrects many problems
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=299385
Closing #331661: extensions/*.jar ship without source code, shipped jar files are installed
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=331661
Closing #331665: dangling symlink
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=331665

Thanks and regards, Daniel

Changed in docbook-xsl:
status: Fix Committed → Fix Released
Revision history for this message
Matthias Klose (doko) wrote :

fixed in 1.68.1.dfsg.1-0.1 (edgy)

Changed in docbook-xsl:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.