dm-writeboost-dkms FTBS with the new hwe 6.8 kernel in jammy

[Andrea Righi]

[Impact]

/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:56:19: error: too few arguments to function ‘dm_io’
   56 | io->err = dm_io(io->io_req, io->num_regions, io->regions, &io->err_bits);
      | ^~~~~
In file included from /var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost.h:37,
                 from /var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:23:
./include/linux/dm-io.h:82:5: note: declared here
   82 | int dm_io(struct dm_io_request *io_req, unsigned int num_regions,
      | ^~~~~
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c: In function ‘wb_io_internal’:
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:82:23: error: too few arguments to function ‘dm_io’
   82 | err = dm_io(io_req, num_regions, regions, err_bits);
      | ^~~~~
./include/linux/dm-io.h:82:5: note: declared here
   82 | int dm_io(struct dm_io_request *io_req, unsigned int num_regions,
      | ^~~~~
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c: In function ‘writeboost_status’:
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:1899:9: warning: enumeration value ‘STATUSTYPE_IMA’ not handled in switch [-Wswitch]
 1899 | switch (type) {
      | ^~~~~~
make[3]: *** [scripts/Makefile.build:243: /var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.o] Error 1

[Test case]

install both GA and HWE kernels, and

 $ sudo apt install dm-writeboost-dkms

then check that the build for both kernels succeeds

[Fix]

Backport the changes from the dm-writeboost-dkms module in Noble to properly support the new 6.8 kernel ABI.

[Regression potential]

System using the dm-writeboost-dkms may experience regressions especially with the new kernel, in that case we may see regressions affecting storage performance.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: dm-writeboost-dkms 2.2.13-1ubuntu3
ProcVersionSignature: User Name 6.8.0-35.35.1~22.04.1-lowlatency 6.8.4
Uname: Linux 6.8.0-35-lowlatency x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Fri Jun 21 07:15:29 2024
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: dm-writeboost
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Test build with the new 6.8 hwe kernel:

dm-writeboost.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

Test build with the GA kernel 5.15:

dm-writeboost.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

[Robie Basak (racb)]

Please amend the Test Plan to make it clear that testing both the GA and HWE kernels is required. I expect to see this in the Test Plan for every HWE backport fix (and if it's not required then an explanation as to why).

I understand that I could just do this myself but it feels like every time I look at an HWE backport fix this isn't in the Test Plan, so I'm pushing back now to get this done properly from the beginning. That way there will be less effort for everyone at a time that the SRU queues are quite large and efficiency matters.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted dm-writeboost into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dm-writeboost/2.2.13-1ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Paolo Pisati (p-pisati)]

$ dkms status
dm-writeboost/2.2.13, 5.15.0-113-generic, x86_64: installed
dm-writeboost/2.2.13, 6.8.0-38-generic, x86_64: installed

GA:
$ lsmod | grep write
dm_writeboost 49152 0

HWE:
$ lsmod | grep write
dm_writeboost 61440 0

build, install and load fine on GA and HWE kernels.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dm-writeboost - 2.2.13-1ubuntu4

---------------
dm-writeboost (2.2.13-1ubuntu4) jammy; urgency=medium

  * Support Linux 6.8 ABI (LP: #2069997):
    - debian/patches/0010-dm-writeboost-linux-6.8-abi.patch

 -- Andrea Righi <email address hidden> Fri, 21 Jun 2024 07:29:50 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for dm-writeboost has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.