dm-writeboost-dkms FTBS with the new hwe 6.8 kernel in jammy

[Andrea Righi]

[Impact]

/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:56:19: error: too few arguments to function ‘dm_io’
   56 | io->err = dm_io(io->io_req, io->num_regions, io->regions, &io->err_bits);
      | ^~~~~
In file included from /var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost.h:37,
                 from /var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:23:
./include/linux/dm-io.h:82:5: note: declared here
   82 | int dm_io(struct dm_io_request *io_req, unsigned int num_regions,
      | ^~~~~
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c: In function ‘wb_io_internal’:
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:82:23: error: too few arguments to function ‘dm_io’
   82 | err = dm_io(io_req, num_regions, regions, err_bits);
      | ^~~~~
./include/linux/dm-io.h:82:5: note: declared here
   82 | int dm_io(struct dm_io_request *io_req, unsigned int num_regions,
      | ^~~~~
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c: In function ‘writeboost_status’:
/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.c:1899:9: warning: enumeration value ‘STATUSTYPE_IMA’ not handled in switch [-Wswitch]
 1899 | switch (type) {
      | ^~~~~~
make[3]: *** [scripts/Makefile.build:243: /var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost-target.o] Error 1

[Test case]

 $ sudo apt install dm-writeboost-dkms

[Fix]

Backport the changes from the dm-writeboost-dkms module in Noble to properly support the new 6.8 kernel ABI.

[Regression potential]

System using the dm-writeboost-dkms may experience regressions especially with the new kernel, in that case we may see regressions affecting storage performance.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: dm-writeboost-dkms 2.2.13-1ubuntu3
ProcVersionSignature: User Name 6.8.0-35.35.1~22.04.1-lowlatency 6.8.4
Uname: Linux 6.8.0-35-lowlatency x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Fri Jun 21 07:15:29 2024
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: dm-writeboost
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Test build with the new 6.8 hwe kernel:

dm-writeboost.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

Test build with the GA kernel 5.15:

dm-writeboost.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

[Robie Basak (racb)]

Please amend the Test Plan to make it clear that testing both the GA and HWE kernels is required. I expect to see this in the Test Plan for every HWE backport fix (and if it's not required then an explanation as to why).

I understand that I could just do this myself but it feels like every time I look at an HWE backport fix this isn't in the Test Plan, so I'm pushing back now to get this done properly from the beginning. That way there will be less effort for everyone at a time that the SRU queues are quite large and efficiency matters.