dm-writeboost dkms: build failure with linux-hwe-5.11

[Andrea Righi]

[Impact]

The following build error is reported when building this module with the new linux-hwe-5.11:

dm-writeboost-metadata.c:984:9: warning: parameter names (without types) in function declaration
  984 | struct superblock_record_device uninitialized_var(record);
      | ^~~~~~~~~~~~~~~~~~~~~~~~
dm-writeboost-metadata.c:985:32: error: ‘record’ undeclared (first use in this function); did you mean ‘record_id’?
  985 | err = read_superblock_record(&record, wb);
      | ^~~~~~
      | record_id

[Test plan]

$ sudo apt install dm-writeboost-dkms

Build error in reported in the build log.

[Fix]

Fix by applying the following upstream commits (from https://github.com/akiradeveloper/dm-writeboost) to properly support the 5.11 kernel:

 32fc003 - Fix Linux 5.9 build: remove uninitialized_var() usage
 d89ea5c - blkdev_issue_flush: discard unused memory allocation flags

[Where problems could occur]

Potential build breakage with some really old kernels.

[Other]

NB! dkms ftbfs fixes must be built in security, such that after SRU process in -proposed & -updates it can be copied into -security pocket too.

[Andrea Righi (arighi)]

debdiff in attach seems to fix the build errors with 5.11.

[Dimitri John Ledkov (xnox)]

NB! dkms ftbfs fixes must be built in security, such that after SRU process in -proposed & -updates it can be copied into -security pocket too.

[Dimitri John Ledkov (xnox)]

Created bileto ppa

https://bileto.ubuntu.com/#/ticket/4601

https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4601/+packages

Changed to build against security pocket only.

Uploaded to it

$ dput ppa:ci-train-ppa-service/4601 dm-writeboost_2.2.9-1ubuntu1.3_source.changes
D: Splitting host argument out of ppa:ci-train-ppa-service/4601.
D: Setting host argument.
Checking signature on .changes
gpg: /tmp/dm-writeboost_2.2.9-1ubuntu1.3_source.changes: Valid signature from 9B8EC849D5EF70ED
Checking signature on .dsc
gpg: /tmp/dm-writeboost_2.2.9-1ubuntu1.3.dsc: Valid signature from 9B8EC849D5EF70ED
Uploading to ppa (via sftp to ppa.launchpad.net):
  Uploading dm-writeboost_2.2.9-1ubuntu1.3.dsc: done.
  Uploading dm-writeboost_2.2.9-1ubuntu1.3.debian.tar.xz: done.
  Uploading dm-writeboost_2.2.9-1ubuntu1.3_source.buildinfo: done.
  Uploading dm-writeboost_2.2.9-1ubuntu1.3_source.changes: done.
Successfully uploaded packages.

Once it is built in security only, will binary copy into focal unapproved.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted dm-writeboost into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dm-writeboost/2.2.9-1ubuntu1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

Confirmed that dm-writeboost 2.2.9-1ubuntu1.3 autopkgtest is built and tested successfully with focal/linux-hwe-5.11 5.11.0-24-generic:

amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/d/dm-writeboost/20210705_155802_029cc@/log.gz
arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/d/dm-writeboost/20210705_160137_a988c@/log.gz
ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/d/dm-writeboost/20210705_155757_a988c@/log.gz
s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/d/dm-writeboost/20210705_155436_029cc@/log.gz

While tests are still successful with focal/linux 5.4.0-79-generic:

amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/d/dm-writeboost/20210705_160217_38735@/log.gz
arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/d/dm-writeboost/20210705_160259_93be7@/log.gz
ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/d/dm-writeboost/20210705_155547_38735@/log.gz
s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/d/dm-writeboost/20210705_155630_93be7@/log.gz

Note: for armhf it has always failed and continues to.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dm-writeboost - 2.2.9-1ubuntu1.3

---------------
dm-writeboost (2.2.9-1ubuntu1.3) focal; urgency=medium

  * Linux 5.11 compatibility (LP: #1932257):
    - debian/patches/0004-Fix-Linux-5.9-build-remove-uninitialized_var-usage.patch
    - debian/patches/0005-Linux-5.11-accomodate-part_stat_read-argument-change.patch

 -- Andrea Righi <email address hidden> Thu, 17 Jun 2021 07:35:05 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for dm-writeboost has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.