dkms invokes the PRE_BUILD command from the wrong working directory
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dkms (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: dkms
If a PRE_BUILD command is defined in a dkms.conf file, then it is invoked as $dkms_tree/
Expected behavior is that PRE_BUILD be always invoked from the $dkms_tree/
The attached patch results in the expected behavior. I noticed this glitch because I'm working on a DKMS package for the ZFS filesystem; the SPL module uses a configure script to create some things in the build area.
ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: dkms 2.1.1.2-3ubuntu1.1 [modified: usr/sbin/dkms]
ProcVersionSign
Uname: Linux 2.6.35-24-generic x86_64
NonfreeKernelMo
Architecture: amd64
Date: Thu Jan 13 15:47:34 2011
PackageArchitec
ProcEnviron:
LANG=en_US.utf8
SHELL=/bin/bash
SourcePackage: dkms
Related branches
tags: | added: patch |
Looks good to me. Thanks.
commit 7dff4a08397bcaa b9ea478129cc4ea 2523e387dc
Author: Mario Limonciello <email address hidden>
Date: Thu Jan 13 17:01:10 2011 -0600
If a PRE_BUILD command is defined in a dkms.conf file, then it is $module/ $module_ version/ source/ $pre_build in the tree/$module/ $module_ version/ source/ is linked to src/$module- $module_ version/ and should be therefore be read-only
invoked as $dkms_tree/
current working directory. This is incorrect behavior because PRE_BUILD
could modify or generate source files. Also note that
$dkms_
/usr/
regardless.
Expected behavior is that PRE_BUILD be always invoked from the tree/$module/ $module_ version/ build/ temporary area.
$dkms_
Thanks Darik Horn.