diffstat: bogus parsing of diffs that contain \ No newline at end of file

Bug #269895 reported by Danny van Dyk
2
Affects Status Importance Assigned to Milestone
diffstat (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: diffstat

When piping a git diff output through diffstat i stumbled upon:

dvandyk@rho $ git diff HEAD tag4/ | diffstat
 folien.tex | 2 --
 1 file changed, 2 deletions(-)

while my changeset clearly had this diff:

dvandyk@rho $ git diff HEAD tag4/
...
 \begin{frame}
- \frametitle{...}}
-\end{frame}
\ No newline at end of file
+ \frametitle{...}

The number of added lines has been completely neglected. It seems to me that diffstat stops parsing a diff when it encounters the line "\ No newline at end of file". Reporting it as diffstat bug, unless somebody can point me to documentation that contradicts me.

diffstat:
  Installed: 1.45-2
  Candidate: 1.45-2
  Version table:
 *** 1.45-2 0
        500 http://de.archive.ubuntu.com hardy/main Packages
        100 /var/lib/dpkg/status

Revision history for this message
Thomas Dickey (dickey-his) wrote :

This was fixed upstream in

http://invisible-island.net/diffstat/CHANGES

31-Aug-2009
 diffstat 1.49

 add special case for no-newline message from some diff's (Ubuntu
 #269895).

Revision history for this message
François Marier (fmarier) wrote :

This is fixed in the 1.51-1 package which has just been uploaded to Debian unstable.

Changed in diffstat (Ubuntu):
status: New → Fix Committed
Revision history for this message
François Marier (fmarier) wrote :

Fixed in 1.52-1 which is now in Maverick

Changed in diffstat (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.