Ubuntu

The error appears if to use --no-ok key, dialog return incorrect code.

Reported by Pontiy_Pilat on 2009-02-24
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
dialog (Debian)
New
Undecided
Unassigned
dialog (Ubuntu)
Medium
Unassigned

Bug Description

Binary package hint: dialog

The error appears if to use --no-ok key, dialog return incorrect code.

Pontiy_Pilat (p-p) wrote :
Serge Hallyn (serge-hallyn) wrote :

Thanks for submitting this bug.

Do you still find this to be valid? If so, can you show us a detailed test case with which can we reproduce? ('--no-ok' seems to work as I would expect it to on oneiric).

Changed in dialog (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Pontiy_Pilat (p-p) wrote :

dialog --clear --inputmenu "a" 20 50 10 "Username:" "a"

Button "rename" - work.

dialog --clear --nook --inputmenu "a" 20 50 10 "Username:" "a"

Button "rename" no work.

Reproduce on Precise.

Serge Hallyn (serge-hallyn) wrote :

Confirmed, I also reproduced on precise.

Changed in dialog (Ubuntu):
importance: Low → Medium
status: Incomplete → Confirmed
Serge Hallyn (serge-hallyn) wrote :

Note that the attached patch no longer applies, but moreover doesn't seem like it would work (at least not any more).

THe function it patches (dlg_ok_buttoncode()) is not being called at all. Rather, dlg_defaultno_button() seems to do the wrong thing, ignoring the fact that nook was given, and returning 0.

Pontiy_Pilat (p-p) on 2012-05-11
tags: added: hardy lucid precise
Pontiy_Pilat (p-p) wrote :

This mistake is a new bug in Ubuntu Precise =)

The Old bug is already fixed.

CHANGES
2011/06/30
        + add/use macro dlg_enter_buttoncode() to improve implementation of
          "--nook" option (report by xDog Walker).
#New bug
2010
/01/19
        + correct mapping of button-codes with --nook option (report by Lebedev
          Vadim).
#Fix old bug

There are new bug fix in the attachment.

Serge Hallyn (serge-hallyn) wrote :

Ah - thanks for that :)

Serge Hallyn (serge-hallyn) wrote :

Thanks, that fixed it for me.

Serge Hallyn (serge-hallyn) wrote :

Forwarded the debdiff to debian (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=673041), but i dont' have upload rights myself.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.