[phone-app] + [messaging-app] + [address-book-app] list tug actions should collapse after user moves view
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Ubuntu Music App |
Undecided
|
Andrew Hayzen | ||
| Ubuntu UX |
High
|
Olga Kemmet | ||
| address-book-app |
Undecided
|
Renato Araujo Oliveira Filho | ||
| address-book-app (Ubuntu) |
Undecided
|
Unassigned | ||
| dialer-app (Ubuntu) |
Undecided
|
Unassigned | ||
| messaging-app (Ubuntu) |
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu) |
High
|
Zsombor Egri | ||
| Vivid |
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
Undecided
|
Unassigned |
Bug Description
build r120
Steps to reproduce:
1. open phone app
2. carry out a bottom edge swipe to access your RECENT
3. swipe any list item to the left or right
4. now scroll your list view a little bit down or up, make sure the list item actions stay in view
Actual Result: the actions remain on the screen, they only collapse if it hides behind the header or bottom of the view
Expected result: if user starts to scroll the list view while a list item shows additional actions, the list item should collapse.
Users are carrying out a different actions in that case and are likely not being interested anymore in the revealed list item actions.
Same behaviour applies for the messaging app and the address-book-app.
Related branches
- PS Jenkins bot: Approve (continuous-integration) on 2014-12-03
- Tim Peeters: Approve on 2014-12-02
-
Diff: 4615 lines (+4323/-22)35 files modifiedcomponents.api (+57/-0)
documentation/overview.qdoc (+5/-0)
modules/Ubuntu/Components/Themes/Ambiance/ListItemPanel.qml (+180/-0)
modules/Ubuntu/Components/Themes/Ambiance/ListItemStyle.qml (+36/-0)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+4/-0)
modules/Ubuntu/Components/plugin/plugin.cpp (+13/-0)
modules/Ubuntu/Components/plugin/plugin.pro (+14/-2)
modules/Ubuntu/Components/plugin/propertychange_p.cpp (+76/-0)
modules/Ubuntu/Components/plugin/propertychange_p.h (+39/-0)
modules/Ubuntu/Components/plugin/quickutils.cpp (+23/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+1/-0)
modules/Ubuntu/Components/plugin/ucaction.h (+2/-0)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+1260/-0)
modules/Ubuntu/Components/plugin/uclistitem.h (+126/-0)
modules/Ubuntu/Components/plugin/uclistitem_p.h (+202/-0)
modules/Ubuntu/Components/plugin/uclistitemactions.cpp (+541/-0)
modules/Ubuntu/Components/plugin/uclistitemactions.h (+113/-0)
modules/Ubuntu/Components/plugin/uclistitemactions_p.h (+61/-0)
modules/Ubuntu/Components/plugin/uclistitemactionsattached.cpp (+247/-0)
modules/Ubuntu/Components/plugin/uclistitemattached.cpp (+207/-0)
modules/Ubuntu/Components/plugin/uclistitemstyle.cpp (+70/-0)
modules/Ubuntu/Components/plugin/uclistitemstyle.h (+53/-0)
modules/Ubuntu/Components/plugin/ucstyleditembase.cpp (+2/-4)
modules/Ubuntu/Test/UbuntuTestCase.qml (+3/-6)
tests/qmlapicheck.sh (+1/-1)
tests/resources/listitems/ListItemTest.qml (+201/-0)
tests/unit/tst_performance/ItemList.qml (+30/-0)
tests/unit/tst_performance/ListItemList.qml (+30/-0)
tests/unit/tst_performance/ListItemWithActionsList.qml (+43/-0)
tests/unit/tst_performance/ListItemWithInlineActionsList.qml (+41/-0)
tests/unit/tst_performance/ListItemsBaseList.qml (+29/-0)
tests/unit/tst_performance/ListItemsEmptyList.qml (+29/-0)
tests/unit/tst_performance/tst_performance.cpp (+7/-8)
tests/unit/tst_performance/tst_performance.pro (+7/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+570/-0)
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-12-17
- Ubuntu Phablet Team: Pending requested 2014-12-15
-
Diff: 15 lines (+5/-0)1 file modifiedsrc/imports/Ubuntu/Contacts/ContactDelegate.qml (+5/-0)
- Victor Thompson: Approve on 2015-01-10
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration) on 2015-01-09
-
Diff: 15 lines (+5/-0)1 file modifiedcommon/ListItemWithActions.qml (+5/-0)
summary: |
- [phone-app] list tug actions should collapse after user moves view + [phone-app] + [messaging-app] + [address-book-app] list tug actions + should collapse after user moves view |
description: | updated |
Changed in ubuntu-ux: | |
assignee: | nobody → Olga Kemmet (olga-kemmet) |
importance: | Undecided → High |
status: | New → Fix Committed |
Olga Kemmet (olga-kemmet) wrote : | #2 |
Marking back to "new" because the tag says ota-1. We are aware that this can not be done for rtm.
Changed in ubuntu-ui-toolkit: | |
status: | Invalid → New |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Zsombor Egri (zsombi) |
Changed in ubuntu-ui-toolkit: | |
status: | New → Triaged |
importance: | Undecided → High |
status: | Triaged → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → In Progress |
no longer affects: | ubuntu-ui-toolkit |
Zsombor Egri (zsombi) wrote : | #3 |
The new ListItem can operate on this, however needs 1.2 imports, which is yet in unstable state. AFAIK the apps linked are not using the toolkit's list items, thus for RTM and OTA-1, their fix must be proprietary one. Depending which OTA will take Vivid, this can be ported to use teh new ListItem from toolkit.
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Launchpad Janitor (janitor) wrote : | #4 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+
---------------
ubuntu-ui-toolkit (1.1.1364+
[ Zsombor Egri ]
* Theming fixes: application theming, binding loop fix, auto-theming
moved into MainView and it is applicable only on Ambiance and
SuruDark, SuruGradient is no longer auto-themed.
Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
LP: #1389792.
* ServiceProperties component to Ubuntu.Components 1.1.
Fixes: LP: #1391877.
* New ListItem component base. Support for leading/trailing actions.
Exported in Ubuntu.Components 1.2 UNSTABLE release.
Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
* removing failing ServiceProperties and app-theming branches
* Application theming ant other theming related binding loop fixes
* ServiceProperties DBus property watcher
[ Christian Dywan ]
* Do the default theme check properly: for non-debug and without
build errors.
* Don't activate the control in ListItem.Standard implicitly.
Fixes: LP: #1372563.
* Improve AutoPilot caret dragging test cases.
* Use new qt_gl_set_
Fixes: LP: #1397979.
* Add sortCaseSensitivity to the SortFilterModel example.
Fixes: LP: #1391034.
* Change offending links into bold font. Fixes: LP: #1395011.
[ Daniel d'Andrada ]
* This is needed by unity8 for the "shell rotation" feature (ie
shell does all the rotation work instead of apps rotating
themselves). unity8's dialogs (like the power dialog when you
long press the power button) should follow its parent item
rotation and size, as one would expect, and not be sneakily
reparented to the scene root item, in which case the shell
UI would be rotated but its dialog would not.
Related bug LP: #1394511. Fixes: LP: #1394511.
[ Tim Peeters ]
* Remove the old header separator style. Fixes: LP: #1372590.
[ Loïc Molinari ]
* Made the UCAlarmPrivate destructor private.
[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in music-app: | |
assignee: | nobody → Andrew Hayzen (andrew-hayzen) |
status: | New → In Progress |
Fix committed into lp:music-app at revision 773, scheduled for release in music-app, milestone music-app-
Changed in music-app: | |
status: | In Progress → Fix Committed |
Launchpad Janitor (janitor) wrote : | #6 |
This bug was fixed in the package address-book-app - 0.2+15.
---------------
address-book-app (0.2+15.
[ Ubuntu daily release ]
* New rebuild forced
[ Renato Araujo Oliveira Filho ]
* Reset ListWithAction swipe state if list view start to flicking (LP:
#1383870)
* Replaced "X" (close icon) to "<" (back icon) on application header.
(LP: #1373517, #1373494)
* Implemented search for unaccented contact names. (LP: #1367906)
* Fix check for keyboard visibility. (LP: #1404309)
-- Ubuntu daily release <email address hidden> Sun, 11 Jan 2015 23:38:55 +0000
Changed in address-book-app (Ubuntu): | |
status: | New → Fix Released |
Changed in music-app: | |
status: | Fix Committed → Fix Released |
Changed in address-book-app: | |
status: | New → Fix Committed |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
no longer affects: | messaging-app |
no longer affects: | dialer-app (Ubuntu) |
affects: | dialer-app → dialer-app (Ubuntu) |
Changed in address-book-app: | |
status: | Fix Committed → Fix Released |
Olga Kemmet (olga-kemmet) wrote : | #7 |
I am not sure why this is marked as "fix released" because this issue still persist on vivid. At least for the telephony apps.
I am marking this bug as invalid for ubuntu-ui-toolkit, because the UITK does not have support (yet) for left/right swiping of list actions (that will be added in Ubuntu.Components 1.2, not for rtm). The apps currently have a custom implementation of this feature so it needs to be fixed there.