invoke_incoming_call() produces an unhandled exception apport report
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dialer-app |
Fix Released
|
Undecided
|
Dimitri John Ledkov | ||
dialer-app (Ubuntu) |
Fix Released
|
Undecided
|
Dimitri John Ledkov | ||
ofono (Ubuntu) |
Invalid
|
Undecided
|
Tony Espy |
Bug Description
Looking at the autopilot tests:
def invoke_
"""Invoke an incoming call for test purpose."""
# magic number 199 will cause a callback from 1234567; dialing 199
# itself will fail, so quiesce the error
subprocess.
That does not check that dial-number succeeded and did not generate tracebacks.
Later, it is expected than incomming call is comming...
def test_incoming(
"""Incoming call"""
number = "1234567"
# wait for incoming call, accept; it would be nicer to fake-click the
# popup notification, but as this isn't generated by dialer-app it
# isn't exposed to autopilot
[
], stdout=
# call back is from that number
# stop watch should start counting
try:
except MismatchError as e:
This indicates there is a problem with a test (setup is not verified that incoming call is actually there), and I'm not sure how the test manages to pass.... by virtue of catching the MismatchError?
I'll be investigating further, to see if dial-number is getting invoked correctly or not, and why it times out.
Related branches
- Martin Pitt: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 45 lines (+10/-4)1 file modifiedtests/autopilot/dialer_app/helpers.py (+10/-4)
Changed in dialer-app (Ubuntu): | |
assignee: | nobody → Dimitri John Ledkov (xnox) |
Changed in ofono (Ubuntu): | |
assignee: | nobody → Tony Espy (awe) |
Changed in dialer-app: | |
assignee: | nobody → Martin Pitt (pitti) |
Changed in dialer-app (Ubuntu): | |
status: | New → Confirmed |
Changed in dialer-app: | |
status: | New → Confirmed |
Changed in dialer-app: | |
status: | Triaged → Fix Released |
Right, so dial-number fails in both python2 and python3 editions, the later one is the only one that generates a whoopsie crash file.
bug 1287659
I'm thinking, instead of doing external call to dial-number, why can't the AP tests themself do dbus call to ofono to invoke the callback? Afterall dial-number script is not doing anything else...