Invalid field given (XSBC_Original_Maintainer) via dh_elpa_test

[Lukas Märdian]

When working on the 'cider' package, I was not able to build the package via 'debuild' after calling 'update-maintainer', to change the maintainer in debian/control to:

Maintainer: Ubuntu Developers <email address hidden>
XSBC-Original-Maintainer: Debian Emacs addons team <email address hidden>

On focal and groovy debuild [-S] fails with the following error:
   dh_elpa_test
Invalid field given (XSBC_Original_Maintainer) at /usr/share/perl5/Debian/Control.pm line 122.
make: *** [debian/rules:4: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

Everything works fine, if I remove the XSBC-Original-Maintainer field.

The failing debdiff is attached.

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: libdebian-source-perl 0.109
ProcVersionSignature: Ubuntu 5.4.0-40.44-generic 5.4.44
Uname: Linux 5.4.0-40-generic x86_64
ApportVersion: 2.20.11-0ubuntu27.4
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: i3
Date: Mon Jul 6 15:35:36 2020
InstallationDate: Installed on 2018-04-28 (800 days ago)
InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Release amd64 (20180426)
PackageArchitecture: all
SourcePackage: dh-make-perl
UpgradeStatus: Upgraded to focal on 2020-05-12 (55 days ago)

[Lukas Märdian (slyon)]

It looks like looks_like_an_x_field() has a wrong implementation (in /usr/share/perl5/Debian/Control/Stanza.pm)

It allows XB or XS or XC but not XSBC.

[gregor herrmann (gregoa)]

On Mon, 06 Jul 2020 14:00:42 -0000, Lukas Märdian wrote:

> It looks like looks_like_an_x_field() has a wrong implementation (in
> /usr/share/perl5/Debian/Control/Stanza.pm)
> It allows XB or XS or XC but not XSBC.

Thanks, fixed in git:
https://salsa.debian.org/perl-team/modules/packages/dh-make-perl

Specifically
https://salsa.debian.org/perl-team/modules/packages/dh-make-perl/-/commit/6f23020a4370aadd1441a51560e97b3b592980ac

Cheers,
gregor
--
 .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-

[Launchpad Janitor (janitor)]

This bug was fixed in the package dh-make-perl - 0.113

---------------
dh-make-perl (0.113) unstable; urgency=medium

  * Add test and runtime dependency on libpod-parser-perl.
    Required for Perl 5.32.
  * Debian::WNPP::Query: use HTTPS for bugs.debian.org links.
  * t/Control.t: add more testcases for X(SBC)-* fields.
  * Debian::Control::Stanza: fix looks_like_an_x_field() function.
    Debian Policy defines "X followed by one or more of S, B, C" fields in
    control files. looks_like_an_x_field() so far only accepted one of them,
    which breaks e.g. Ubuntu's XSBC-Original-Maintainer field.
    Adjust regexp to the one used by Dpkg::Control::FieldsCore.
    Thanks to Lukas Märdian for the bug report. (LP: #1886461)
  * Debian::DpkgLists: ignore dpkg-query status messages in _cat_lists().
  * DhMakePerl::Command::make: use 'apt-get install' instead of 'dpkg -i'
    for installing the created and built package. The former also takes
    care of dependencies.
    Thanks to Paul Wise for the bug report. (Closes: #954827)
  * Update some copyright attributions.
  * Hardening support for arch:any packages (a.k.a. C/XS modules):
    + Update test suite: expect debian/rules with hardening flags for
      arch:any package.
    + Separate debian/rules template into an arch:all and an arch:any
      version (again). The latter contains hardening flags.
    + DhMakePerl::Command::Packaging: use the arch:{all,all} debian/rules
      template depending on the architecture of the binary package.

 -- gregor herrmann <email address hidden> Sun, 12 Jul 2020 01:13:06 +0200