Backport dh-golang 1.13 to trusty

Bug #1595021 reported by Michael Hudson-Doyle on 2016-06-22
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dh-golang (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Michael Hudson-Doyle

Bug Description

[Impact]
We want to backport docker and related packages to Trusty. The dh-golang in trusty is too old and lacks features used by the packages we want to backport (particularly the support for the DH_GOLANG_BUILDPKG and DH_GOLANG_EXCLUDES variables to control which packages are built, but also the support for reading the Go import path from the control file).

dh-golang is up to version 1.18 in sid/yakkety now but that causes 1 package (ngrok) in trusty to ftbfs. 1.13 seems to be a sweet spot in terms of having features and fixes we need but not breaking any packages in trusty.

[Test case]
In fact, there is already a package in trusty that uses tries to use the newer features and has a bug as a result: golang-logrus builds an _all golang-logrus-dev package that contains a i386 binary:

mwhudson@aeglos:~/tmp$ lintian golang-logrus-dev_0.7.3-1~ubuntu0.14.04.1_all.deb
E: golang-logrus-dev: arch-independent-package-contains-binary-or-object usr/bin/basic

So a test case would be to rebuild this package and see if this lintian error goes away.

[Regression potential]
There is obviously some potential for regressions here, but I've rebuilt all reverse dependencies of dh-golang in trusty twice, once with the version of dh-golang in trusty:

    https://launchpad.net/~mwhudson/+archive/ubuntu/trusty-go-rebuilds

and once with a backport of dh-golang 1.13:

    https://launchpad.net/~mwhudson/+archive/ubuntu/trusty-go-rebuilds-dh-golang-2

I debmirror-ed both PPAs and compared the results (with find and debdiff). Apart from fixing the above bug in golang-logrus, the only differences are in golang-doozer, golang-openldap, and golang-goprotobuf-dev and are down to the fact that dh-golang now by default includes .proto, .c and .s files in -dev packages. This is at worst harmless and quite possibly would make the packages more useful.

Changed in dh-golang (Ubuntu):
status: New → Invalid
Changed in dh-golang (Ubuntu Trusty):
status: New → In Progress
assignee: nobody → Michael Hudson-Doyle (mwhudson)
Martin Pitt (pitti) wrote :

Thanks for doing the rebuild check in advance, that's very convincing!

Changed in dh-golang (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed

Hello Michael, or anyone else affected,

Accepted dh-golang into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dh-golang/1.13~0ubuntu0~14.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dh-golang - 1.13~0ubuntu0~14.04

---------------
dh-golang (1.13~0ubuntu0~14.04) trusty; urgency=medium

  * Build for trusty. (LP: #1595021)

 -- Michael Hudson-Doyle <email address hidden> Thu, 16 Jun 2016 10:46:14 +1200

Changed in dh-golang (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for dh-golang has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Anders Kaseorg (andersk) wrote :

This was updated in trusty and not xenial, so now the version in xenial is older than in trusty (bug 1780679).

Changed in dh-golang (Ubuntu):
status: Invalid → New
tags: added: trusty verification-done-trusty xenial
removed: verification-done
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers