[edit-patch] producing wrong file when creating patch name ending with dot

Bug #851812 reported by Mahyuddin Susanto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devscripts (Ubuntu)
New
Undecided
Unassigned

Bug Description

[edit-patch] producing wrong file when creating patch name ending with dot, for example 02_fix_FTBFS_GCC_4.6

to produce this errors:
$ pull-lp-source packages
$ cd packages-version
$ edit-patch 02_fix_FTBFS_GCC_4.6

patches file produces 02_fix_FTBFS_GCC_4 not 02_fix_FTBFS_GCC_4.6, see https://launchpadlibrarian.net/80055444/clutter-gesture_0.0.2.1-2ubuntu2.dsc.debdiff

Benjamin Drung (bdrung)
affects: ubuntu-dev-tools (Ubuntu) → devscripts (Ubuntu)
Revision history for this message
Akbarkhon Variskhanov (kbar) wrote :

That's because the scripts attempts to normalize patch extension. Currently, everything is stripped off until the first period, inclusive.

normalize_patch_extension() {
...
    PATCHNAME=${PATCHNAME%.*}
}

This is done to ensure that the correct extensions for quilt/dpatch/cdbs are appended.

Your issue is valid but I'm not quite sure what the solution would be.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.