licensecheck fails to parse copyright if a / is contained

Bug #1466098 reported by Michael Zanetti on 2015-06-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devscripts (Debian)
Fix Released
Unknown
devscripts (Ubuntu)
High
Unassigned

Bug Description

Since the last update in wily, licensecheck fails to recognize copyright headers of this format:

Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).

Seems removing the "/" makes it pass again. This is the standard format used in Qt copyright headers and it looks fine to me. Previous versions of licensecheck parsed this fine.

Didier Roche (didrocks) wrote :

After some analysis, it started in 2.15.5.

The commit creating it is https://anonscm.debian.org/cgit/collab-maint/devscripts.git/commit/?id=97ac51f54568728618695b92907a8ac4b87a1709, more especially, due to this change:
- if ($match !~ m%^\s*$copyright_disindicator_regex%ix) {
+ if ($match !~ $copyright_disindicator_regex) {

If we revert that one, with devscript 2.15.5, I can get the digia copyright back:
  [Copyright: 2014 Digia Plc and/or its subsidiary(-ies)]

I'm unsure about that change (and ther other optimization related into that commit). I guess we can introduce one test for that use case. Opening the bug in debian BTS for this.

Didier Roche (didrocks) on 2015-06-17
Changed in devscripts (Ubuntu):
status: New → Triaged
importance: Undecided → High
Changed in devscripts (Debian):
status: Unknown → New
Changed in devscripts (Debian):
status: New → Fix Committed
Changed in devscripts (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.