proposed-migration for detox 2.0.0-3

[Nick Rosbrook]

detox 2.0.0-3 is stuck in -proposed.

This package FTBFS on all arches, e.g.[1]:

dh_auto_build
 make -j4
make[1]: Entering directory '/<<PKGBUILDDIR>>'

...SNIP...

gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=3 -DDATADIR=\"/usr/share\" -DSYSCONFDIR=\"/etc\" -DYY_NO_INPUT -DYY_NO_UNPUT -D_FORTIFY_SOURCE=2 -Wall -Werror -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/detox-2.0.0-3 -flto=auto -Werror -fstack-clash-protection -Werror -fstack-protector-strong -Werror -c -o clean_string.o clean_string.c
<command-line>: error: "_FORTIFY_SOURCE" redefined [-Werror]
<command-line>: note: this is the location of the previous definition
<command-line>: error: "_FORTIFY_SOURCE" redefined [-Werror]
<command-line>: error: "_FORTIFY_SOURCE" redefined [-Werror]
<command-line>: note: this is the location of the previous definition
<command-line>: note: this is the location of the previous definition
<command-line>: error: "_FORTIFY_SOURCE" redefined [-Werror]
<command-line>: note: this is the location of the previous definition
cc1: all warnings being treated as errors
make[3]: *** [Makefile:565: builtin_table.o] Error 1
make[3]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[3]: *** [Makefile:565: clean_string.o] Error 1
cc1: all warnings being treated as errors
make[3]: *** [Makefile:565: config_file_yacc.o] Error 1
cc1: all warnings being treated as errors
make[3]: *** [Makefile:565: config_file_lex.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:409: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: *** [Makefile:544: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:7: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

It seems that a simple fix is to remove the hard coded -D_FORTIFY_SOURCE lines in the relevant Makefiles, and instead let the distro build flags take precedence.

[1]https://launchpadlibrarian.net/744524447/buildlog_ubuntu-oracular-amd64.detox_2.0.0-3_BUILDING.txt.gz

[Nick Rosbrook (enr0n)]

I did forward this to debian, but unfortunately forgot to include the link in Bug-Debian in the patch header.

[Nick Rosbrook (enr0n)]

There is still one more build-time test failure on armhf: https://launchpadlibrarian.net/747678259/buildlog_ubuntu-oracular-armhf.detox_2.0.0-3ubuntu1_BUILDING.txt.gz

[Timo Aaltonen (tjaalton)]

removing from oracular-proposed

[Timo Aaltonen (tjaalton)]

The version of detox in the proposed pocket of Oracular that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.