The build problem due to header dependency [-pedantic]
Bug #988443 reported by
Seong-ho Cho
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Undecided
|
Unassigned | ||
dee |
Fix Released
|
Low
|
Unassigned | ||
dee (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
when we compile this source code after get this tarball package
someone who uses >=gcc-4.5.x, can see like under messages.
dee-1.0.
dee-1.0.
when we eliminate type definition from dee-filter.h
we can also see like above message.
so I suggest that
# src/dee-filter.h:33
// typedef struct _DeeFilter DeeFilter;
# src/dee-
// typedef struct _DeeFilter DeeFilter;
for eliminating circular header dependency and successsful build.
Related branches
lp:~jfi/dee/LP988443
- Michal Hruby (community): Approve
- Jean-Philippe Orsini (community): Needs Resubmitting
-
Diff: 38 lines (+1/-5)3 files modifiedsrc/dee-filter.h (+0/-2)
src/dee-model-reader.h (+0/-2)
src/dee-transaction.h (+1/-1)
lp:~sil2100/dee/ubuntu_6.2
(Merged)
Changed in dee: | |
importance: | Undecided → Low |
status: | New → Triaged |
milestone: | none → 1.0.12 |
summary: |
- The build problem due to header dependency + The build problem due to header dependency [-pedantic] |
Changed in dee: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
milestone: | none → 6.2 |
status: | New → Fix Committed |
Changed in dee: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu): | |
status: | New → Fix Released |
To post a comment you must log in.
clang is also raising an error while trying to compile dee or compile a source file including dee.h: dee-1.0/ dee.h:41: dee-1.0/ dee-filter- model.h: 57:27: error: redefinition of typedef 'DeeFilter' is invalid in C [-Wtypedef- redefinition]
^ dee-1.0/ dee-model- reader. h:33:27: note: previous definition is here
^ dee-1.0/ dee.h:42: dee-1.0/ dee-filter. h:33:27: error: redefinition of typedef 'DeeFilter' is invalid in C [-Wtypedef- redefinition]
^ dee-1.0/ dee-filter- model.h: 57:27: note: previous definition is here
^ desktop: /tmp$ clang `pkg-config --cflags dee-1.0` ./test.c dee-1.0/ dee.h:41: dee-1.0/ dee-filter- model.h: 57:27: error: redefinition of typedef 'DeeFilter' is invalid in C [-Wtypedef- redefinition]
^ dee-1.0/ dee-model- reader. h:33:27: note: previous definition is here
^ dee-1.0/ dee.h:42: dee-1.0/ dee-filter. h:33:27: error: redefinition of typedef 'DeeFilter' is invalid in C [-Wtypedef- redefinition]
^ dee-1.0/ dee-filter- model.h: 57:27: note: previous definition is here
^
clang `pkg-config --cflags dee-1.0` ./test.c
In file included from ./test.c:1:
In file included from /usr/include/
/usr/include/
typedef struct _DeeFilter DeeFilter;
/usr/include/
typedef struct _DeeFilter DeeFilter;
In file included from ./test.c:1:
In file included from /usr/include/
/usr/include/
typedef struct _DeeFilter DeeFilter;
/usr/include/
typedef struct _DeeFilter DeeFilter;
2 errors generated.
jporsini@
In file included from ./test.c:1:
In file included from /usr/include/
/usr/include/
typedef struct _DeeFilter DeeFilter;
/usr/include/
typedef struct _DeeFilter DeeFilter;
In file included from ./test.c:1:
In file included from /usr/include/
/usr/include/
typedef struct _DeeFilter DeeFilter;
/usr/include/
typedef struct _DeeFilter DeeFilter;