decibel-audio-player shouldn't use notifications with actions

Bug #328609 reported by David Barth on 2009-02-12
2
Affects Status Importance Assigned to Milestone
Decibel Audio Player
Undecided
François Ingelrest
decibel-audio-player (Ubuntu)
Low
Emilio Pozuelo Monfort

Bug Description

Binary package hint: decibel-audio-player

When a new track starts playing, a notification bubble appears giving the song details, and containing a “Skip track” button. The button should be made conditional on whether the notification server supports actions.

Scott Kitterman (kitterman) wrote :

Won't fixing the Ubuntu task as this package is in Universe and MOTU is not manned to support this kind of divergence from upstream.

Changed in decibel-audio-player:
status: New → Won't Fix
Emilio Pozuelo Monfort (pochu) wrote :

This is a valid bug as decibel-audio-player should check whether the notification-daemon implementation supports actions.

Changed in decibel-audio-player:
importance: Undecided → Low
status: Won't Fix → Triaged
Emilio Pozuelo Monfort (pochu) wrote :

Hi François,

According to the notification-daemon spec, the "Actions" feature may or may not be implemented by the daemon, and apps should check whether support exists before using it.

Actions: "This functionality may not be implemented by the notification server, conforming clients should check if it is available before using it"

http://www.galago-project.org/specs/notification/0.9/x81.html

Checking for 'actions' in pynotify.get_server_caps() should do the trick.

Cheers

I wontfixed the Ubuntu task because I don't think this is something we
should diverge from upstream on. I did not mark it invalid.

I'm not putting it to wontfix again because we don't revert reversions. I
would ask you to reconsider if we should maintain a diff for this
indefinitely and put it back to wontfix.

Scott Kitterman wrote:
> I'm not putting it to wontfix again because we don't revert reversions. I
> would ask you to reconsider if we should maintain a diff for this
> indefinitely and put it back to wontfix.

It if was a wishlist or something else I'd consider it, but since decibel is not
following the spec it can be considered buggy and thus I'll leave it open and
patch it if necessary (either here or even in Debian), but hope François will
consider fixing this upstream making a local fix unnecessary.

François Ingelrest (athropos) wrote :

Ok, I'll fix that.

François Ingelrest (athropos) wrote :

Fixed on trunk. Now, showing the button is disabled by default, and the checkbox in the configuration dialog is enabled only if 'actions' can be found in pynotify.get_server_caps().

Changed in decibel-audio-player:
assignee: nobody → athropos
status: New → Fix Committed
Emilio Pozuelo Monfort (pochu) wrote :

Awesome, thanks François.

Changed in decibel-audio-player:
assignee: nobody → pochu
François Ingelrest (athropos) wrote :

De nada.

François Ingelrest (athropos) wrote :

See v1.01

Changed in decibel-audio-player:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers