FTBFS in Trusty

Bug #1743787 reported by Eric Desrochers
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
debian-installer (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Medium
Eric Desrochers

Bug Description

[Impact]

d-i FBTFS is a blocker for any future preseed SRU that require a d-i rebuild to create for instance a new mini.iso (Minimal image of Ubuntu).

[Test Case]

* Perform the following :

 $ pull-lp-source debian-installer trusty
 $ cd debian-installer-*
 $ dch -i # Bump version in debian/changelog
 $ debuild -S -k<YOUR_LP_GPG_KEY>
 $ dput ppa:<YOUR_LP_ID>:<YOUR_PPA_NAME> ../debian-installer*.source.changes

* The build will fail with the following error in the build log
------------------------------------------------------------------
...
Using signed grub version 2.02~beta2-9ubuntu1.14
cp: cannot stat ‘/usr/lib/shim/shim.efi.signed’: No such file or directory
make[7]: *** [x86_grub_efi] Error 1
make[6]: *** [_build] Error 2
make[5]: *** [flavour_build] Error 2
make[4]: *** [medium_build] Error 2
make[3]: *** [subarch_build] Error 2
make[2]: *** [all_build] Error 2
make[2]: Leaving directory `/<<PKGBUILDDIR>>/build'
make[1]: *** [build-images] Error 2
make[1]: Leaving directory `/<<PKGBUILDDIR>>'
make: *** [install] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-arch gave error exit status 2
------------------------------------------------------------------

[Regression Potential]

No regression anticipated, it will simply fix the FTBFS by making sure d-i reflect new shim-signed package reality.

[Other Info]

Only trusty is impacted.

[Original Description]

When building d-i on Trusty as-is, we are getting a FBTFS situation with the following error:

# Launchpad Buildlog
...
Using signed grub version 2.02~beta2-9ubuntu1.14
cp: cannot stat ‘/usr/lib/shim/shim.efi.signed’: No such file or directory
make[7]: *** [x86_grub_efi] Error 1
make[6]: *** [_build] Error 2
make[5]: *** [flavour_build] Error 2
make[4]: *** [medium_build] Error 2
make[3]: *** [subarch_build] Error 2
make[2]: *** [all_build] Error 2
make[2]: Leaving directory `/<<PKGBUILDDIR>>/build'
make[1]: *** [build-images] Error 2
make[1]: Leaving directory `/<<PKGBUILDDIR>>'
make: *** [install] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-arch gave error exit status 2

The problem is that d-i for Trusty hasn't been built for a long time and recent shim-signed change never been adapt into d-i for Trusty which explain why it no longer build properly anymore.

When looking shim-signed pkg on Trusty, there is no presence of "/usr/lib/shim/shim.efi.signed" anymore but we see "/usr/lib/shim/shimx64.efi.signed"
https://pastebin.canonical.com/207767/

# debian-installer src ci=ode per release :
t/debian-installer-20101020ubuntu318.42/build/util/efi-image: cp /usr/lib/shim/shim.efi.signed "$workdir/boot$efi_name.efi"

x/debian-installer-20101020ubuntu451.18/build/util/efi-image: cp "/usr/lib/shim/shim$efi_name.efi.signed" "$workdir/boot$efi_name.efi"
z/debian-installer-20101020ubuntu504/build/util/efi-image: cp "/usr/lib/shim/shim$efi_name.efi.signed" "$workdir/boot$efi_name.efi"
a/debian-installer-20101020ubuntu523.1/build/util/efi-image: cp "/usr/lib/shim/shim$efi_name.efi.signed" "$workdir/boot$efi_name.efi"
b/debian-installer-20101020ubuntu527/build/util/efi-image: cp "/usr/lib/shim/shim$efi_name.efi.signed" "$workdir/boot$efi_name.efi"

The required shim change in d-i for Trusty never been integrated which explain why it works as expected on all releases but Trusty.

Trusty is the only release who still have an hard-coded no longer existing file and not using the "$efi_name" variable.

Eric Desrochers (slashd)
Changed in debian-installer (Ubuntu):
status: New → Fix Released
tags: added: ftbfs
Revision history for this message
Eric Desrochers (slashd) wrote :

As per my conversation with cyphermox, he is agree with the above analysis and will take care of the SRU for this.

Thanks cyphermox.

Changed in debian-installer (Ubuntu Trusty):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
status: New → Confirmed
Eric Desrochers (slashd)
tags: added: sts
description: updated
Changed in debian-installer (Ubuntu Trusty):
importance: Undecided → Medium
Eric Desrochers (slashd)
description: updated
description: updated
Eric Desrochers (slashd)
description: updated
Revision history for this message
Eric Desrochers (slashd) wrote :

Here's the debdiff[1] to fix the FTBFS situation for "d-i" on Trusty.

Note that Joshua (who is subscribed to this bug) will shortly need a rebuild of "d-i" to pick up his future change in preseed.

Depending on how long it take for Joshua to provide the preseed patch.... I think we should wait Joshua's preseed SRU, to do the necessary "d-i" rebuild + FTBFS fix in the same time.

[1] - lp1743787-trusty.debdiff

- Eric

Revision history for this message
Eric Desrochers (slashd) wrote :
Eric Desrochers (slashd)
Changed in debian-installer (Ubuntu Trusty):
assignee: Mathieu Trudel-Lapierre (cyphermox) → Eric Desrochers (slashd)
status: Confirmed → In Progress
Eric Desrochers (slashd)
tags: added: sts-sponsor-slashd-done
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted debian-installer into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/debian-installer/20101020ubuntu318.43 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in debian-installer (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-trusty
Revision history for this message
Eric Desrochers (slashd) wrote :

[VERIFICATION TRUSTY]

With regard to the FTBFS situation on debian-installer, the build is now completed successfully as the following link indicate:

https://launchpad.net/ubuntu/+source/debian-installer/20101020ubuntu318.43

The rest of the verification will need to be done for LP: #1745531 (preseed change).

- Eric

tags: added: verification-done verification-done-trusty
removed: verification-needed verification-needed-trusty
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package debian-installer - 20101020ubuntu318.43

---------------
debian-installer (20101020ubuntu318.43) trusty; urgency=medium

  * Include $efi_name in shim filename. (LP: #1743787)
  * Rebuild to pick up the latest change in preseed. (LP: #1745531)

 -- Eric Desrochers <email address hidden> Fri, 19 Jan 2018 09:20:25 -0500

Changed in debian-installer (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for debian-installer has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.