a bug in dhcp exit hook script of ddclient

[Dmitry Redkin]

the ddclient DHCP exit hook script looks like:

[ -x /usr/sbin/ddclient ] || exit 0
[ -f /etc/default/ddclient ] || exit 0
. /etc/default/ddclient
[ $run_dhclient = "true" ] || exit 0

case $reason in
    BOUND | RENEW | REBIND)
        /usr/bin/logger -t dhclient $reason, updating IP address with ddclient
        /usr/sbin/ddclient -daemon=0 -syslog > /dev/null 2>&1
        ;;
    *)
        ;;
esac

The error is on line 7. As all the shell programming guides say, when checking a variable you have to quote it, or in case the variable is null (as it is in my case) you will get an error:

/sbin/dhclient-script: 7: [: =: unexpected operator

so the correct line 7 for this script is:

[ "$run_dhclient" = "true" ] || exit 0

Please fix it in LTS also as people start to complain on the forums about this bug already.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Manfred (mejf)]

This bug caused me several hours of headscratching and work. :-(

[Jani Uusitalo (uusijani)]

A fix has recently been committed upstream: https://salsa.debian.org/debian/ddclient/-/commit/82d99d1dfb0fb002a15e081fdc7ccf8f96215dc6