ddclient doesn't update well cache when connection to dyndns server fails

[xavier]

Hi,
I've found a problem on ddclient that writes to cache hosts that are not really updated.

I'm running ddclient 3.8.2 (also tested with 3.8.0/3.8.1) on a computer (Ubuntu 12.04, also tried with 13.10) with an own dyndns server as target server, my config is as follows:

protocol=dyndns2
ip=0.0.0.0
server=dyndns.XXXXXXXXX.XXX
login=XXXXXXX
password=XXXXXXXXXXX
XXXXXX.dyndns.XXXXXXXXX.XXX

I'm using ip=0.0.0.0 because I don't really want to send an IP to the server, doing that the server knows that 0.0.0.0 is not a valid IP and changes with the original source ip.

When the computer has Internet connection all works fine, ddclient connect to the server, the server answer "nochg XXX.XXX.XXX.XXX" with the correct IP address and ddclient writes it to cache.
When the computer loses connecto to Internet, ddclient looks at cache, sees that 0.0.0.0 is different than XXX.XXX.XXX.XXX, tries to connect to the server, it fails and writes 0.0.0.0 to cache intead of skipping, leaving it empty or setting a flag marking hostname not well updated.

I've fixed it with a workaround, but I know it could be done better using flags or something else.

I leave you a patch with that workaround.

Thanks,
Xavier.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: ddclient 3.8.1-1ubuntu2
ProcVersionSignature: Ubuntu 3.11.0-15.23-generic 3.11.10
Uname: Linux 3.11.0-15-generic x86_64
ApportVersion: 2.12.5-0ubuntu2.2
Architecture: amd64
Date: Thu Jan 9 13:12:44 2014
InstallationDate: Installed on 2013-03-28 (287 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Alpha amd64 (20130327)
MarkForUpload: True
PackageArchitecture: all
SourcePackage: ddclient
UpgradeStatus: Upgraded to saucy on 2013-10-17 (83 days ago)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Patch for ddclient 3.8.1-1ubuntu2" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[wimpunk (wimpunk)]

Is this the same bug as reported here: https://sourceforge.net/p/ddclient/bugs/60/?

[xavier (xavier-o)]

Yes, it is.

I've posted in both places, here and in the source of package because probably (if they want to) they will fix it in next version (3.8.3) and actually ubuntu is using 3.8.1.

Is that a problem?

Thanks,
Xavier

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Richard Hansen (rhansen)]

I am assuming this has been fixed upstream. If not, please reopen.