ddcci-driver-linux 0.3.2-1ubuntu1 ADT test failure with linux 5.3.0-9.10

[Seth Forshee]

[Impact]
The DKMS package won't work with new kernels on bionic.

[Test case]
Install and load the modules.

[Regression potential]
This might break the functioning of the module.

-----------------------------------

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/amd64/d/ddcci-driver-linux/20190904_061606_8aa60@/log.gz
    arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/arm64/d/ddcci-driver-linux/20190904_062050_8aa60@/log.gz
    armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/armhf/d/ddcci-driver-linux/20190904_063821_8aa60@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/i386/d/ddcci-driver-linux/20190904_062025_8aa60@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/ppc64el/d/ddcci-driver-linux/20190904_061848_8aa60@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/s390x/d/ddcci-driver-linux/20190904_061558_8aa60@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package ddcci-driver-linux - 0.3.2-2ubuntu2

---------------
ddcci-driver-linux (0.3.2-2ubuntu2) eoan; urgency=medium

  * Fix build warnings and errors with Linux 5.3 (LP: #1842671)
    - debian/patches/0003-Update-ddcci_remove_helper-prototype-for-Linux-5.3.patch
    - debian/patches/0004-Use-M-instead-of-SUBDIRS-for-specifying-module-sourc.patch

 -- Seth Forshee <email address hidden> Wed, 04 Sep 2019 09:31:18 -0500

[Timo Aaltonen (tjaalton)]

Hello Seth, or anyone else affected,

Accepted ddcci-driver-linux into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ddcci-driver-linux/0.3.1-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted ddcci-driver-linux (0.3.1-2ubuntu0.1) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

ddcci-driver-linux/0.3.1-2ubuntu0.1 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#ddcci-driver-linux

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Thadeu Lima de Souza Cascardo (cascardo)]

Preparing to unpack .../ddcci-dkms_0.3.1-2ubuntu0.1_all.deb ...
Unpacking ddcci-dkms (0.3.1-2ubuntu0.1) ...
Setting up ddcci-dkms (0.3.1-2ubuntu0.1) ...
Loading new ddcci-0.3.1 DKMS files...
Building for 5.3.0-23-generic
Building initial module for 5.3.0-23-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

ddcci:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.3.0-23-generic/updates/dkms/

ddcci-backlight.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.3.0-23-generic/updates/dkms/

depmod...

DKMS: install completed.

[Thadeu Lima de Souza Cascardo (cascardo)]

$ sudo dkms build ddcci/0.3.1 -k 4.15.0-70-generic

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area...
make -j1 KERNELRELEASE=4.15.0-70-generic KVER=4.15.0-70-generic -C /var/lib/dkms/ddcci/0.3.1/build....
Signing module:
 - /var/lib/dkms/ddcci/0.3.1/4.15.0-70-generic/x86_64/module/ddcci.ko
 - /var/lib/dkms/ddcci/0.3.1/4.15.0-70-generic/x86_64/module/ddcci-backlight.ko
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
cleaning build area...

DKMS: build completed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ddcci-driver-linux - 0.3.1-2ubuntu0.1

---------------
ddcci-driver-linux (0.3.1-2ubuntu0.1) bionic; urgency=medium

  * Fix build for kernel 5.3 (LP: #1842671).
    - d/p/0001-Fix-incorrect-check-on-null-pointer-after-a-kzalloc.patch
    - d/p/0002-Update-ddcci_remove_helper-prototype-for-Linux-5.3.patch
    - d/p/0003-Use-M-instead-of-SUBDIRS-for-specifying-module-sourc.patch
    - d/p/0004-Skip-build-if-BACKLIGHT_CLASS_DEVICE-off.patch

 -- Marcelo Henrique Cerri <email address hidden> Wed, 13 Nov 2019 17:41:55 -0300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ddcci-driver-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.