Comment 14 for bug 816153

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the debdiffs!

Could you please fix a couple of small details:

1- The debian/changelog refers to the 03-configure.patch changes twice. Please remove one of them.
2- Please add the name of the 16-fix-dlopen.patch patch to the appropriate section in debian/changelog
3- The 16-fix-dlopen.patch patch contains the comment "#nothing found, set libc.so anyway", which is wrong. Please adjust.
4- On my system, LIBRARY_DLOPEN gives two results: /lib/i386-linux-gnu/libdl.so.2 /lib/x86_64-linux-gnu/libdl.so.2. Please fix so it only gets set to a single result. Actually, this probably needs to be fixed better. In a buildd, you most likely won't have multiarch packages, so it probably isn't an issue, but if you try to build on a system with multiarch packages, you may end up with the wrong library paths. Perhaps we should be using DEB_HOST_ARCH or something?