[Xenial] dahdi-dkms fails to build after kernel version 4.4.218

Bug #1878214 reported by Stefan Bader on 2020-05-12
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dahdi-linux (Ubuntu)
Medium
Unassigned
Xenial
Medium
Stefan Bader

Bug Description

In upstream stable 4.4.218, the following patch brings back kref_read() which was re-implemented in dahdi-linux code for kernel versions before 4.11:

commit 408f17931f5451702ad638e1d8511e780f6b56e7
Author: Peter Zijlstra <email address hidden>
Date: Mon Nov 14 17:29:48 2016 +0100

    locking/atomic, kref: Add kref_read()

This needs adjustment now in Xenial for kernels including 4.4.218 and later.

[SRU Justification]

== Impact ==

Dahdi-dkms fails to build for kernels which include upstream stable version 4.4.218 or later.

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/d/dahdi-linux/20200511_051631_1b525@/log.gz

== Fix ==

Disable the internal re-implementation of kref_read() for kernels including upstream stable 4.4.218.

== Testcase ==

Running dkms build for various kernel versions (tested with Ubuntu-4.4.0-178 and Ubuntu-4.4.0-179). With -178 building currently succeeds, with -179 it fails.

== Risk of Regression ==

Low, internal implementation which was backported from kernel 4.11 gets replaced by the kernel function.

Stefan Bader (smb) on 2020-05-12
description: updated
Stefan Bader (smb) wrote :

Fix by disabling the internal definition of kref_read() for kernel versions >= 4.4.218.

Stefan Bader (smb) wrote :
Changed in dahdi-linux (Ubuntu Xenial):
assignee: nobody → Stefan Bader (smb)
importance: Undecided → Medium
status: New → In Progress
Changed in dahdi-linux (Ubuntu):
assignee: Stefan Bader (smb) → nobody
status: In Progress → Invalid
description: updated
Stefan Bader (smb) wrote :

On a Xenial test VM with build-ppa enabled:

ubuntu@test-x1:~$ dkms status
dahdi, 2.10.2~dfsg-1ubuntu4, 4.4.0-178-generic, x86_64: installed
dahdi, 2.10.2~dfsg-1ubuntu4, 4.4.0-179-generic, x86_64: installed

Hello Stefan, or anyone else affected,

Accepted dahdi-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dahdi-linux/1:2.10.2~dfsg-1ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in dahdi-linux (Ubuntu Xenial):
status: In Progress → Fix Committed

All autopkgtests for the newly accepted dahdi-linux (1:2.10.2~dfsg-1ubuntu4) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

dahdi-linux/1:2.10.2~dfsg-1ubuntu4 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#dahdi-linux

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Stefan Bader (smb) wrote :

@sru-team: I checked the autopkgtest status for s390x and that looks like failing is the expected outcome for that arch (http://autopkgtest.ubuntu.com/packages/d/dahdi-linux/xenial/s390x). Could that hint be added (xenial/dahdi-linux on s390x expected to fail) to badtest? Thanks.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers