dahdi-linux 1:2.10.2~dfsg-1ubuntu2 ADT test failure with linux-hwe-edge 4.15.0-23.25~16.04.1

Bug #1779331 reported by Marcelo Cerri on 2018-06-29
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dahdi-linux (Ubuntu)
Undecided
Marcelo Cerri
Xenial
Undecided
Marcelo Cerri

Bug Description

[Impact]

Currently the DKMS package fails to install on supported custom
kernels that are based on 4.15. That includes the current 4.15
hwe-edge and some of the custom and cloud kernels as well.

[Test Case]

Install the dahdi-dkms package with the 4.15 hwe-edge kernel. The
package installation should proceed without any errors.

[Regression Potential]

Although new patches were added, the regression risk is very low since
the new changes are conditionally compiled based on the kernel
version.

Besides that, the new package was tested with the following kernels in
an amd64 environment:

- linux-generic 4.4
- linux-hwe 4.13
- linux-hwe-edge 4.15

The azure kernel doesn't have USB support enabled anymore and I will hint the adt matrix to reflect that.

[Original Description]

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/d/dahdi-linux/20180528_193708_5fee0@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/i386/d/dahdi-linux/20180528_194150_5fee0@/log.gz

Marcelo Cerri (mhcerri) wrote :
tags: added: kernel-adt-failure
Changed in dahdi-linux (Ubuntu):
assignee: nobody → Marcelo Cerri (mhcerri)
status: New → In Progress
description: updated
tags: added: patch
Tyler Hicks (tyhicks) on 2018-07-06
description: updated
Tyler Hicks (tyhicks) on 2018-07-06
Changed in dahdi-linux (Ubuntu):
status: In Progress → Invalid
Changed in dahdi-linux (Ubuntu Xenial):
status: New → In Progress
assignee: nobody → Marcelo Cerri (mhcerri)
Tyler Hicks (tyhicks) wrote :

This debdiff looks mostly good. I had to spend quite a bit of time to figure out where the patches came from. Apparently, they're from this bug:

  https://issues.asterisk.org/jira/browse/DAHLIN-359

I've added the Origin dep-3 tag to each patch. I see that you probably just reused the patches from the Bionic or Cosmic package, which didn't include the origin, but the origin is important to include so that we know where the code is coming from, what kind of review it has gotten, etc.

As mentioned while sponsoring another recent package for you, I don't love the SRU versioning scheme used here. If you look at the current artful, bionic, and cosmic version strings, you can see why it could be a problem in future SRUs. The versioning scheme documented here has been proven to work well:

  https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

I'm sponsoring this one to xenial-proposed since you're following the existing SRU versioning scheme for the package. Thanks for the debdiff! :)

Łukasz Zemczak (sil2100) wrote :

Accepting this as is, but I'm a bit worried that the patches haven't been actually accepted upstream yet? At least looking at Jira, the bug is still 'Triaged', with only comments approving that it 'WFM' (which is why I'm allowing this to get approved, since that's still better than not building at all).

Changed in dahdi-linux (Ubuntu Xenial):
status: In Progress → Fix Committed

Hello Marcelo, or anyone else affected,

Accepted dahdi-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dahdi-linux/1:2.10.2~dfsg-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Marcelo Cerri (mhcerri) wrote :

I have tested the version 1:2.10.2~dfsg-1ubuntu3 and the DKMS package successfully builds and loads on kernels 4.15, which was the issue reported in this bug.

I also have run the ADT tests for the following kernels to ensure there's no regressions:

- linux-generic 4.4
- linux-hwe 4.15
- linux-azure-edge 4.15

tags: added: verification-done verification-done-xenial
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers