[MIR] promote python3-dacite as a pcs dependency

Bug #1989628 reported by Athos Ribeiro
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dacite (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[Availability]
The package dacite is already in Ubuntu universe.
The package dacite build for the architectures it is designed to work on.
It currently builds and works for architetcures: all
Link to package https://launchpad.net/ubuntu/+source/dacite

[Rationale]
The package dacite is required in Ubuntu main for pcs
The package dacite will not generally be useful for a large part of our user base, but is important/helpful still because pcs requires it and is in the MIR process to substitute crmsh.
pcs MIR link: https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1953341

- The package dacite is required in Ubuntu main through the same scheduled requested for the pcs promotion, since pcs depends on it.

[Security]
- No CVEs/security issues in this software in the past

- no `suid` or `sgid` binaries
- no executables in `/sbin` and `/usr/sbin`
- Package does not install services, timers or recurring jobs
- Package does not open privileged ports (ports < 1024)
- Package does not contain extensions to security-sensitive software (filters, scanners, plugins, UI skins, ...)

[Quality assurance - function/usage]
- The package works well right after install

[Quality assurance - maintenance]
- The package is maintained well in Debian/Ubuntu and has not too many
  and long term critical bugs open
  - Ubuntu https://bugs.launchpad.net/ubuntu/+source/dacite/+bug
  - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=dacite
- The package has no important open bugs: https://github.com/konradhalas/dacite/issues
- The package does not deal with exotic hardware we cannot support

[Quality assurance - testing]
- The package runs a test suite on build time, if it fails
  it makes the build fail, link to build log: https://launchpadlibrarian.net/569933354/buildlog_ubuntu-jammy-amd64.dacite_1.6.0-2_BUILDING.txt.gz

- The package runs an autopkgtest, and is currently passing on this list of
  architectures, amd64, arm64, armhf, ppc64el, s390x.
  https://autopkgtest.ubuntu.com/packages/d/dacite

- The package does not have failing autopkgtests tests right now

[Quality assurance - packaging]
- debian/watch is present and works

- debian/control defines a correct Maintainer field

- This package does not yield massive lintian Warnings, Errors
- Latest package build: https://launchpad.net/ubuntu/+source/dacite/1.6.0-2/+build/22431743
- Lintian output attached.
- Lintian overrides are not present

- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies

- The package will not be installed by default

- Packaging and build is easy, link to d/rules https://git.launchpad.net/ubuntu/+source/dacite/tree/debian/rules

[UI standards]
- Application is not end-user facing (does not need translation)

[Dependencies]
No further depends or recommends dependencies that are not yet in main

[Standards compliance]
This package correctly follows FHS and Debian Policy

[Maintenance/Owner]
- Owning Team will be Ubuntu Server
- Team is not yet, but will subscribe to the package before promotion
- This does not use static builds
- This does not use vendored code
- This package is not rust based

The package successfully built during the most recent test rebuild
https://launchpad.net/ubuntu/+archive/test-rebuild-20220914-kinetic/+build/24371057

[Background information]
The Package description explains the package well
Upstream Name is dacite
Link to upstream project https://github.com/konradhalas/dacite

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :
description: updated
Changed in dacite (Ubuntu):
assignee: nobody → Didier Roche-Tolomelli (didrocks)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Review package for dacite

[Summary]
MIR team ACK. Small and easy package in shape. Keep in mind that you need to subscribe the server team before promotion.

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
  - dacite checked with `check-mir`
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- no new python2 dependency
- Python package, but using dh_python

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case

Changed in dacite (Ubuntu):
status: New → Fix Committed
assignee: Didier Roche-Tolomelli (didrocks) → nobody
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the review Didier! The Server team will be subscribed before its promotion.

Revision history for this message
Steve Langasek (vorlon) wrote :

Override component to main
dacite 1.8.0-1 in lunar: universe/misc -> main
python3-dacite 1.8.0-1 in lunar amd64: universe/python/optional/100% -> main
python3-dacite 1.8.0-1 in lunar arm64: universe/python/optional/100% -> main
python3-dacite 1.8.0-1 in lunar armhf: universe/python/optional/100% -> main
python3-dacite 1.8.0-1 in lunar i386: universe/python/optional/100% -> main
python3-dacite 1.8.0-1 in lunar ppc64el: universe/python/optional/100% -> main
python3-dacite 1.8.0-1 in lunar riscv64: universe/python/optional/100% -> main
python3-dacite 1.8.0-1 in lunar s390x: universe/python/optional/100% -> main
8 publications overridden.

Changed in dacite (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.