zfs pool and fs properties are not passed to zfs.zpool_create
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
curtin (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In curtin/block/zfs.py the definition of zpool_create is
def zpool_create(
But this method is called from curtin/
zfs.
So the properties defined in the configuration file are never applied to the pool.
Besides the documentation specifies that zfs filesystem properties are set with fs_properties while in the code it's called zfs_properties. It'd be more consistent to name them identically
ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: curtin (not installed)
ProcVersionSign
Uname: Linux 5.0.0-8-generic x86_64
NonfreeKernelMo
ApportVersion: 2.20.10-0ubuntu25
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Apr 8 11:38:50 2019
InstallationDate: Installed on 2014-07-15 (1728 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: curtin
UpgradeStatus: Upgraded to disco on 2018-03-24 (379 days ago)
Related branches
- Ryan Harper (community): Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 53 lines (+14/-5)2 files modifiedcurtin/commands/block_meta.py (+5/-1)
tests/unittests/test_commands_block_meta.py (+9/-4)
This bug is fixed with commit 47956074 to curtin on branch master. /git.launchpad. net/curtin/ commit/ ?id=47956074
To view that commit see the following URL:
https:/