zfs pool and fs properties are not passed to zfs.zpool_create

Bug #1823682 reported by Jean-Baptiste Lallement on 2019-04-08
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
curtin (Ubuntu)
Undecided
Unassigned

Bug Description

In curtin/block/zfs.py the definition of zpool_create is

def zpool_create(poolname, vdevs, mountpoint=None, altroot=None,
                 pool_properties=None, zfs_properties=None):

But this method is called from curtin/commands/block_meta.py without the pool_properties and zfs_properties:

    zfs.zpool_create(poolname, vdevs_byid,
                     mountpoint=mountpoint, altroot=altroot)

So the properties defined in the configuration file are never applied to the pool.

Besides the documentation specifies that zfs filesystem properties are set with fs_properties while in the code it's called zfs_properties. It'd be more consistent to name them identically

ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: curtin (not installed)
ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1
Uname: Linux 5.0.0-8-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.10-0ubuntu25
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Apr 8 11:38:50 2019
InstallationDate: Installed on 2014-07-15 (1728 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: curtin
UpgradeStatus: Upgraded to disco on 2018-03-24 (379 days ago)

Related branches

Jean-Baptiste Lallement (jibel) wrote :
description: updated

This bug is fixed with commit 47956074 to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=47956074

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package curtin - 18.2-22-g08bf6ff7-0ubuntu1

---------------
curtin (18.2-22-g08bf6ff7-0ubuntu1) disco; urgency=medium

  * New upstream snapshot.
    - Setup kernel-img.conf like base-installer/live-installer did.
      [Dimitri John Ledkov] (LP: #1534162)
    - zfs: pass pool and fs properties to zpool_create
      [Jean-Baptiste Lallement] (LP: #1823682)
    - block_meta: pass lvm_partition size through human2bytes
      [Michael Hudson-Doyle]

 -- Ryan Harper <email address hidden> Thu, 11 Apr 2019 14:22:33 -0500

Changed in curtin (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers