No exception or error message if user tries to load specific reporter using load_reporter method.
Bug #1367486 reported by
Newell Jensen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| curtin |
Fix Released
|
Medium
|
Newell Jensen | ||
| curtin (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Currently, if a user tries to load a specific reporter and there is an error for some reason, an EmptyReporter is returned. An exception should be raised and this information should also be logged so the user knows what the issue is.
Related branches
lp:~newell-jensen/curtin/fix-bug-1367486
- Blake Rouse (community): Approve
-
Diff: 165 lines (+104/-6)3 files modifiedcurtin/reporter/__init__.py (+12/-1)
curtin/reporter/maas.py (+10/-5)
tests/unittests/test_reporter.py (+82/-0)
Revision history for this message
| Blake Rouse (blake-rouse) wrote | #1 |
| Changed in curtin: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Newell Jensen (newell-jensen) |
Revision history for this message
| Scott Moser (smoser) wrote | #2 |
| summary: |
- No exception raised when EmptyReporter is returned from load_reporter + No exception or error message if user tries to load specific reporter + and it can't. Currently just silently returns an EmptyReporter. |
| description: | updated |
| summary: |
No exception or error message if user tries to load specific reporter - and it can't. Currently just silently returns an EmptyReporter. + and using load_reporter method. |
| summary: |
No exception or error message if user tries to load specific reporter - and using load_reporter method. + using load_reporter method. |
| Changed in curtin: | |
| status: | Triaged → Fix Committed |
| no longer affects: | curtin (Ubuntu) |
| Changed in curtin (Ubuntu): | |
| status: | New → Fix Released |
| Changed in curtin: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't think you should raise an exception if a reporter is not defined. Only raise an exception if the report that is defined fails to load.
Some unit test for this as well would be nice.