client tools ignore -h option without port number

[Dariusz Gadomski]

[Impact]
Prevents user from overriding default print server on cmdline if he's not aware of the fact that this bug may be overriden by giving a port number.

[Test Case]
1. Setup 2 cups servers with a shared printer set as default destination: server1, server2.
2. On a trusty client try:
export CUPS_SERVER=server1
lpstat -h server2 -H
3. Expected result:
server2:631
4. Actual result:
server1:631
(server given by CUPS_SERVER is used instead of the one given by -h option).

[Regression Potential]
Minimal. ipp_port is initialized to default value if not given explicitly. Fix is a backport from Xenial version and already present in upstream release.

[Other Info]

* Original bug description:

Some commandline tools (e.g. lp, lpstat) ignore -h option if no port number is given.
This version affects Trusty with cups-client 1.7.2-0ubuntu1.7. Xenial works fine.

Test to reproduce:
1. Setup 2 cups servers with a shared printer set as default destination: server1, server2.
2. On a trusty client try:
export CUPS_SERVER=server1
lpstat -h server2 -H

3. Expected result:
server2:631

4. Actual result:
server1:631
(server given by CUPS_SERVER is used instead of the one given by -h option).

If a port number is given (e.g. server2:631) the commands work as expected.

[Dariusz Gadomski (dgadomski)]

SRU proposal for Trusty.

[Till Kamppeter (till-kamppeter)]

Dariusz, I have uploaded the SRU now. It will soon appear in trusty-proposed.

[Brian Murray (brian-murray)]

Hello Dariusz, or anyone else affected,

Accepted cups into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cups/1.7.2-0ubuntu1.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Dariusz Gadomski (dgadomski)]

Thanks Till & Brian.

In the same environment that served as a reproducer the new version fixes the issue.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cups - 1.7.2-0ubuntu1.8

---------------
cups (1.7.2-0ubuntu1.8) trusty; urgency=medium

  * Fixed processing of server overrides without port numbers. (LP: #1665018)

 -- Dariusz Gadomski <email address hidden> Wed, 15 Feb 2017 15:55:27 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for cups has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.