[MIR] cups-pk-helper
Bug #808829 reported by
Martin Pitt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cups-pk-helper (Ubuntu) |
Fix Released
|
Low
|
Till Kamppeter |
Bug Description
At some point there is a possibility that we want to use gnome-control-
Filing a MIR to start reviewing the package, so that we get an idea whether we should pursue this, or stick to the static group and system-
CVE References
Changed in cups-pk-helper (Ubuntu): | |
assignee: | nobody → Didier Roche (didrocks) |
Changed in cups-pk-helper (Ubuntu): | |
assignee: | Martin Pitt (pitti) → Till Kamppeter (till-kamppeter) |
To post a comment you must log in.
Things that caught my eye during review:
- Uses dbus-glib, should be ported to gdbus at some point. helper- mechanism. c is by and large boilerplate code and looks correct to me. The polkit result is properly checked, and there are no complicated memory operations.
- cups-pk-
- cups.c is rather large, but also pretty straightforward code to translate the dbus interface to the libcups API; it does some rather thorough input value validity checks.
- uses gettext properly
- Good maintenance in Debian so far, although the package is only half a year old; no bug reports
- No Ubuntu bugs, but not surprising as the package hasn't been used by default
- straightforward packaging