Bug #776264 “FFe: Please merge cryptsetup 2:1.4.1-2 (main) from ...” : Bugs : cryptsetup package : Ubuntu

Revision history for this message

Lorenzo De Liso (blackz) wrote on 2011-05-03:

#1

cryptsetup_1.2.0-2ubuntu1.debdiff Edit (51.3 KiB, text/plain)

Changed in cryptsetup (Ubuntu):
importance:	Undecided → Wishlist

Revision history for this message

Chris Halse Rogers (raof) wrote on 2011-05-31:

#2

Gah. About a week after you filed this, Debian updated to cryptsetup 1.3.0. From the changelog, it looks like the more recent Debian packages contain fixes that we want.

I'm sorry nobody's got to this before now. Could you please re-do this merge against the more recent debian revision, and I'll review and upload once you're done?

Brian Murray (brian-murray) on 2011-05-31

tags:

added: patch

Revision history for this message

Zak Kipling (zak-k) wrote on 2011-06-14:

#3

cryptsetup_1.3.0-3ubuntu1.debdiff Edit (52.7 KiB, text/plain)

I've done precisely this here, in order to get loop-AES compatibility support. It all seems to be working fine in a Natty environment.

My diff against the Debian cryptsetup 1.3.0-3 source package is attached.

Revision history for this message

Zak Kipling (zak-k) wrote on 2011-08-03:

#4

I'm just wondering if there's any chance of this version update making it into Oneiric -- and if there's anything further I can do to facilitate this?

Revision history for this message

Jean-Louis Dupond (dupondje) wrote on 2012-03-02: Re: Please merge cryptsetup 2:1.4.1-2 (main) from debian unstable (main)

#5

Updated debdiff Edit (53.5 KiB, text/plain)

This version contains alot of bugfixes.
See:
http://code.google.com/p/cryptsetup/wiki/Cryptsetup120
http://code.google.com/p/cryptsetup/wiki/Cryptsetup130
http://code.google.com/p/cryptsetup/wiki/Cryptsetup131
http://code.google.com/p/cryptsetup/wiki/Cryptsetup140
http://code.google.com/p/cryptsetup/wiki/Cryptsetup141

summary:

- Please merge cryptsetup 2:1.2.0-2 (main) from debian unstable (main)
+ Please merge cryptsetup 2:1.4.1-2 (main) from debian unstable (main)

Revision history for this message

Jean-Louis Dupond (dupondje) wrote on 2012-03-04:

#6

Did some more test on this. And everything seems to be working.

What I tested:
Created LUKS device with current version in Precise.
Upgraded cryptsetup
Mounted correctly, no issues.
Created LUKS device with the new version.
Mounted that

Everything seems to do its thing.

I think that having also the TRIM option in cryptsetup is a good thing to have.
Surely that more and more people are getting a SSD.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-06:

#7

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in cryptsetup (Ubuntu):
status:	New → Confirmed

Felix Geyer (debfx) on 2012-03-06

summary:

- Please merge cryptsetup 2:1.4.1-2 (main) from debian unstable (main)
+ FFe: Please merge cryptsetup 2:1.4.1-2 (main) from debian unstable
+ (main)

Revision history for this message

David Hoffman (hoffman) wrote on 2012-03-06:

#8

The version currently in Pangolin Beta 1 (1.1.3) and the next version are both deprecated at "http://code.google.com/p/cryptsetup". It would be great to get this freshened up before Pangolin is released.

tags:

added: upgrade-software-version

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2012-03-07:

#9

ACK! The current version is obsolete.

Revision history for this message

Felix Geyer (debfx) wrote on 2012-03-07:

#10

The merge looks good. Only two small comments:

- The diff in debian/cryptsetup.dirs isn't necessary anymore as debian/rules has a "mkdir -p" call.

- The diff in debian/cryptsetup.postinst isn't necessary anymore. The version in lucid is greater than 2:1.0.6+20090405.svn49-1ubuntu8.

Revision history for this message

Martin Pitt (pitti) wrote on 2012-03-07:

#11

Please test this on a system which uses an encrypted root/home partition, otherwise it seems ok to me. Thanks!

Revision history for this message

Jean-Louis Dupond (dupondje) wrote on 2012-03-07:

#12

new debdiff Edit (52.4 KiB, text/plain)

Attached a debdiff with the remarks fixed.
I'm going to test this now on a Precise system with crypted root.

Revision history for this message

Jean-Louis Dupond (dupondje) wrote on 2012-03-07:

#13

Tested this with an encrypted root, and this works without issues!

Revision history for this message

Martin Pitt (pitti) wrote on 2012-03-08:

#14

libpam-mount is the remaining reverse dependency of the now obsolete libcryptsetup1, I'll handle the update to libcryptsetup4.

Changed in libpam-mount (Ubuntu):
assignee:	nobody → Martin Pitt (pitti)
importance:	Undecided → High
status:	New → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-08:

#15

Download full text (12.4 KiB)

This bug was fixed in the package cryptsetup - 2:1.4.1-2ubuntu1

---------------
cryptsetup (2:1.4.1-2ubuntu1) precise; urgency=low

  [ Jean-Louis Dupond ]
  * Merge from debian unstable (LP: #776264), remaining changes:
    - debian/cryptdisks.functions: Suppress "Starting init crypto disks" message
      in "init" phase, to avoid writing over fsck progress text.
    - debian/cryptroot-hook: Quiet warnings from find on arches that
      don't have all the kernel/{arch,crypto} bits we're testing for.
    - debian/control:
      + Bump initramfs-tools Suggests to Depends: so system is not
        potentially rendered unbootable.
      + Depend on plymouth.
    - Add debian/cryptdisks-{enable,udev}.upstart.
    - debian/cryptdisks.functions:
      + new function, crypttab_start_one_disk, to look for the named source
        device in /etc/crypttab (by device name, UUID, or label) and start it
        if configured to do so
    - debian/cryptdisks{,-early}.init: Make the 'start' action of the init
      script a no-op, this should be handled entirely by the upstart job;
      and fix the LSB header to not declare this should be started in
      runlevel 'S'
    - debian/rules:
      + Do not install start symlinks for init scripts, and
        install debian/cryptdisks-{enable,udev}.upstart scripts.

  [ Steve Langasek ]
  * debian/cryptdisks.functions: handle the case where crypttab contains a
    name for the source device that is not the kernel's preferred name for
    it (as is the case for LVs).

cryptsetup (2:1.4.1-2) unstable; urgency=low

  * acknowledge NMU. Thanks to Michael Biebl. (closes: #659182)
  * don't print error for non-encrypted rootfs in initramfs cryptroot hook.
    Thanks to Jamie Heilman and Christoph Anton Mitterer for bugreports.
    (closes: #659087, #659106)
  * use dmsetup splitname to extract VG name from $node in initramfs cryptroot
    hook. Thanks to Kai Weber for the bugreport, Milan Broz and Claudio
    Imbrenda for suggestions and patches. (closes: #659235)

cryptsetup (2:1.4.1-1.1) unstable; urgency=low

  * Non-maintainer upload.
  * Fix dangling .so symlink. Don't hard code the library version but use
    readlink instead to determine where the .so symlink should point at.
    (closes: #659182)

cryptsetup (2:1.4.1-1) unstable; urgency=low

  * new upstream release (1.4.0 + 1.4.1) (closes: #647851)
    - fixes typo in german translation. (closes: #645528)
    - remove patches, all incorporated upstream.
    - soname bump, rename library package to libcryptsetup4
  * check for busybox in initramfs cryptroot hook, and install the sed binary
    in case it's either not installed or not activated. (closes: #591853)
  * add checks for 'type $KEYSCRIPT' to initscripts cryptdisks.functions, and
    to cryptroot initramfs script/hook. this adds support for keyscripts inside
    $PATH. thanks to Ian Jackson for the suggestion. (closes: #597583)
  * use argument '--sysinit' for vgchange in cryptroot initramfs script. Thanks
    to Christoph Anton Mitterer for the suggestion.
  * add option for discard/trim features to crypttab and initramfs scripts.
    Thanks to intrigeri and Peter Colberg for patches. (closes: #64...

This bug was fixed in the package cryptsetup - 2:1.4.1-2ubuntu1

---------------
cryptsetup (2:1.4.1-2ubuntu1) precise; urgency=low

[ Jean-Louis Dupond ]
  * Merge from debian unstable (LP: #776264), remaining changes:
    - debian/cryptdisks.functions: Suppress "Starting init crypto disks" message
      in "init" phase, to avoid writing over fsck progress text.
    - debian/cryptroot-hook: Quiet warnings from find on arches that
      don't have all the kernel/{arch,crypto} bits we're testing for.
    - debian/control:
      + Bump initramfs-tools Suggests to Depends: so system is not
        potentially rendered unbootable.
      + Depend on plymouth.
    - Add debian/cryptdisks-{enable,udev}.upstart.
    - debian/cryptdisks.functions:
      + new function, crypttab_start_one_disk, to look for the named source
        device in /etc/crypttab (by device name, UUID, or label) and start it
        if configured to do so
    - debian/cryptdisks{,-early}.init: Make the 'start' action of the init
      script a no-op, this should be handled entirely by the upstart job;
      and fix the LSB header to not declare this should be started in
      runlevel 'S'
    - debian/rules:
      + Do not install start symlinks for init scripts, and
        install debian/cryptdisks-{enable,udev}.upstart scripts.

[ Steve Langasek ]
  * debian/cryptdisks.functions: handle the case where crypttab contains a
    name for the source device that is not the kernel's preferred name for
    it (as is the case for LVs).

cryptsetup (2:1.4.1-2) unstable; urgency=low

* acknowledge NMU. Thanks to Michael Biebl. (closes: #659182)
  * don't print error for non-encrypted rootfs in initramfs cryptroot hook.
    Thanks to Jamie Heilman and Christoph Anton Mitterer for bugreports.
    (closes: #659087, #659106)
  * use dmsetup splitname to extract VG name from $node in initramfs cryptroot
    hook. Thanks to Kai Weber for the bugreport, Milan Broz and Claudio
    Imbrenda for suggestions and patches. (closes: #659235)

cryptsetup (2:1.4.1-1.1) unstable; urgency=low

* Non-maintainer upload.
  * Fix dangling .so symlink. Don't hard code the library version but use
    readlink instead to determine where the .so symlink should point at.
    (closes: #659182)

cryptsetup (2:1.4.1-1) unstable; urgency=low

* new upstream release (1.4.0 + 1.4.1) (closes: #647851)
    - fixes typo in german translation. (closes: #645528)
    - remove patches, all incorporated upstream.
    - soname bump, rename library package to libcryptsetup4
  * check for busybox in initramfs cryptroot hook, and install the sed binary
    in case it's either not installed or not activated. (closes: #591853)
  * add checks for 'type $KEYSCRIPT' to initscripts cryptdisks.functions, and
    to cryptroot initramfs script/hook. this adds support for keyscripts inside
    $PATH. thanks to Ian Jackson for the suggestion. (closes: #597583)
  * use argument '--sysinit' for vgchange in cryptroot initramfs script. Thanks
    to Christoph Anton Mitterer for the suggestion.
  * add option for discard/trim features to crypttab and initramfs scripts.
    Thanks to intrigeri and Peter Colberg for patches. (closes: #648868)
  * print $target on error in initramfs hook. Thanks to Daniel Hahler for the
    bugreport. (closes: #648192)
  * add a warning about using decrypt_derived keyscript for devices with
    persistent data. Thanks to Arno Wagner for pointing this out.
  * remove quotes from resume device candidates at get_resume_devs() in
    initramfs hook script. Thanks to Johannes Rohr. (closes: #634017)
  * support custom $TABFILE, thanks to Douglas Huff. (closes: #638317)
  * fix get_lvm_deps() in initramfs cryptroot hook to add all physical volumes
    of lvm volume group that contains the rootfs logical volume, even if the
    rootfs is lv is not spread over all physical volumes. Thanks to Christian
    Pernegger for bugreport and patch. (closes: #634109)
  * debian/initramfs/cryptroot-script: Move check for maximum number of tries
    behind the while loop, to make the warning appear in case that maximum
    number of tries is reached. Thanks to Chistian Lamparter for bugreport and
    patch. (closes: #646083)
  * incorporate changes to package descriptions and debconf templates that
    suggested by debian-l10n-english people. Special thanks go to Justin B Rye.
  * acknowledge NMU, thanks a lot to Christian Perrier for his great work on
    the i18n front. (closes: #633105, #641719, #641839, #641947, #642470,
    #640056, #642540, #643633, #643962, #644853)
  * add and update debconf translations:
    - italian, thanks to Milo Casagrande, Francesca Ciceri. (closes: #656933)
    - german, thanks to Erik Pfannenstein. (closes: #642147)
    - spanish, thanks to Camaleón. (closes: #658360)
    - russian, thanks to Yuri Kuzlov (closes: #654676)
  * set architecture to linux-any, depends on linux kernel anyway. Thanks to
    Christoph Egger. (closes: #638257)
  * small updates to the copyright file.
  * add targets build-indep and build-arch to debian/rules, thanks to lintian.

cryptsetup (2:1.3.0-3.1) unstable; urgency=low

* Non-maintainer upload.
  * Fix pending l10n issues. Debconf translations:
    - French (Julien Patriarca).  Closes: #633105
    - Vietnamese (Hung Tran).  Closes: #641719
    - Portuguese (Miguel Figueiredo).  Closes: #641839
    - Russian (Yuri Kozlov).  Closes: #641947
    - Swedish (Martin Bagge / brother).  Closes: #642470,#640056
    - Czech (Michal Simunek).  Closes: #642540
    - Dutch; (Jeroen Schot).  Closes: #643633
    - Spanish; (Camaleón).  Closes: #643962
    - Danish (Joe Hansen).  Closes: #644853

cryptsetup (2:1.3.0-3) unstable; urgency=low

* drop the loopback magick from cryptdisks scripts. Mario 'Bitkoenig' Holbe
    pointed out, that auto-destruction support was added to the loopback driver
    with kernel 2.6.25. Given, that even lenny has a more recent kernel,
    support for kernels < 2.6.25 is not required any more. (closes: #626458)
  * add debconf question 'prerm/active-mappings' with priority high to prerm
    maintainer script. will warn about active dm-crypt mappings before the
    package is removed/purged. (closes: #626641)
  * add lintian-override for 'cryptsetup: no-debconf-config', as the debconf
    question in prerm doesn't require a debconf config script.
  * add debian/patches/03_create_fix_keyfile.patch. (closes: #626738)

cryptsetup (2:1.3.0-2) unstable; urgency=low

* fix changelog of 2:1.3.0-1 release, thanks to Thorsten Glaser for the hint

cryptsetup (2:1.3.0-1) unstable; urgency=low

* new upstream release
    - automatically allocates loopback device for container files. update the
      cryptdisks functions to only setup loopback device for kernel < 2.6.35.
      otherwise, let cryptsetup do the magic itself.
    - introduces maximum default keyfile size, see --help for value. manually
      set the keyfile size with --keyfile-size in order to overwrite the limit.
    - adds luksChangeKey command for changing passphrase/keyfile in one step
    - adds loopAES compatibility command loopaesOpen
    - remove d/patches/01_luksAddKey_return_code.patch, incorporated upstream
  * add gettext support to luksformat script. Thanks to intrigeri for initial
    patch, and adduser sources for implementation ideas. (closes: #558405)
  * fix KEYSCRIPT checks in cryptdisks.functions for empty values.
  * update REAMDE.gnupg and initramfs cryptgnupg hook script:
    - warn about keys being copied to initramfs.
    - fix the documentation to provide working examples.
  * update README.Debian and related documentation:
    - add a section about the 'special' keyscripts askpass and passdev
      (closes: #601314)
    - update several sections, remove reference to lenny
  * add debian/patches/01_create_fix_size.patch, to fix a regression in 1.2.0
    where the size argument was ignored for create command (closes: #624828)
  * add debian/patches/02_manpage.patch, escapes minus signs in manpage
  * remove usplash support from cryptroot initramfs script, askpass and
    keyscripts, add plymouth support to keyscripts. (closes: #620923)
  * ignore options like cipher, hash, size, etc. for luks commands in
    cryptdisks. mention this in the crypttab manpage. (closes: #619249)
  * again check for existance of /lib/cryptsetup/cryptdisks.functions before
    sourcing it in cryptdisks(-early).init. required if cryptsetup is removed
    but not purged, where initscripts are still around. (closes: #625468)
  * bump standards-version to 3.9.2, no changes needed.
  * debian/libcryptsetup1.symbols: update, 1.3.0 adds new function symbols

cryptsetup (2:1.2.0-2) unstable; urgency=low

* upload to unstable.
  * fixes a ftbfs due to updated libgpg-error and libgcrypt11 build-
    dependencies. (closes: #614530)
  * install cryptkeyctl initramfs hook, needed for keyctl keyscript in
    initramfs, thanks to Maik Zumstrull (closes: #610750)
  * use 'egrep -c' instead of wc in cryptdisks_st* scripts, wc might not be
    available as it's located at /usr/bin. Thanks to Mario 'BitKoenig' Holbe
    for bugreport and patch. (closes: #611747)
  * add debian/patches/01_luksAddKey_return_code.patch, fixes the luksAddKey
    return code when the master key is used. (closes: #610366)
  * fix luksformat script to invoke usage() with --help. (closes: #612947)
  * add a paragraph about known upgrade issues to the crypttab manpage. this
    paragraph strongly suggests to configure cipher, hash and keysize for
    plain dm-crypt devices. (closes: #612452)
  * fix examples in crypttab manpage, cipher, hash and keysize should be
    configured for plain dm-crypt devices.
  * luksformat: invoke udevadm settle between mkfs.vfat and luksClose, to
    prevent possible race conditions. This is a workaround. (closes: #601886)
  * update lintian-overrides for new lintian from experimental.
  * fix spelling mistake in README.Debian thanks to lintian.
  * update short and long description for udebs to mention udeb and
    debian-installer. This satisfies lintian.
  * fix get_resume_device() in initramfs cryptroot hook script to add source
    device for decrypt_derived keyscript in case it's not the root device.
    Thanks to Robert Lange and mahashakti89 for bugreport. (closes: #592430)

cryptsetup (2:1.2.0-1) experimental; urgency=low

* new major upstream release (closes: #603804)
    - adds text version of FAQ
    - adds new options --use-random and --use-urandom for MK generation
    - fixes luksRemoveKey to not ask for remaining keyslot passphrase
    - no longer supports luksDelKey command (replaced by luksKillSlot)
    - no longer supports reload command, dmsetup reload should be used instead
    - adds support to change the UUID later (with --uuid cmd option)
    - adds --dump-master-key option for luksDump command
    - no luksOpen, luksFormat and create for open devices (closes: #600208)
    - remove debian/patches/01_manpage.patch, incorporated upstream
    - and many more changes, see upstream changelog for further information
    - update debian/libcryptsetup1.symbols
  * invoke update-initramfs at cryptsetup removal in order to not leave behind
    a broken initramfs. thanks to ubuntu for the hint.
  * link dynamically against libgcrypt11 and libgpg-error0 now that the
    libraries have been moved to /lib. add versioned depends for libcryptsetup1
    on (libgcrypt >= 1.4.6-2) and libgpg-error0 (>= 1.10-0.1).
  * debian/initramfs/cryptroot-script: prereq 'cryptroot-prepare' added in
    order to support cryptroot to depend on custom initramfs scripts. thanks
    to Marc Haber for the suggestion. (closes: #601311)
  * debian/cryptdisks.functions:
    + fix check for ownership and permissions of $key to work with slighly
      different output of 'ls -l' with selinux enabled. (closes: #600522)
    + fix $TRIES implementation to support TRIES=0 again. (closes: #602501)
  * change 'echo -e' to 'printf' in debian/initramfs/cryptroot-script. thanks
    to checkbashisms script devscripts for spotting that bashism.
  * add a libcryptsetup1-udeb library package for debian-installer in order to
    satisfy cryptsetup-udeb dependencies with dynamically linked binary.
    Version the build-depends on libgcrypt11-dev to (>= 1.4.6-3), to satisfy
    udeb library dependencies.
  * change 'XC-Package-Type: udeb' to 'Package-Type: udeb' in debian/control
  * add debian/cryptsetup.apport from Ubuntu, install only for dist=Ubuntu.
    build-depends on dpkg-dev (>= 1.15.1) is required for this to work.
 -- Jean-Louis Dupond <jean-louis@dupond.be>   Thu, 08 Mar 2012 07:32:40 +0100

Changed in cryptsetup (Ubuntu):
status:	Confirmed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-08:

#16

This bug was fixed in the package libpam-mount - 2.10-2build1

---------------
libpam-mount (2.10-2build1) precise; urgency=low

* No-change rebuild against libcryptsetup4. (LP: #776264)
-- Martin Pitt <email address hidden> Thu, 08 Mar 2012 07:37:20 +0100

Changed in libpam-mount (Ubuntu):
status:	In Progress → Fix Released

Ubuntu
cryptsetup package

FFe: Please merge cryptsetup 2:1.4.1-2 (main) from debian unstable (main)

Bug Description

Related branches

Other bug subscribers

Patches

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	cryptsetup (Ubuntu)	Fix Released	Wishlist	Unassigned
	libpam-mount (Ubuntu)	Fix Released	High	Martin Pitt

Ubuntucryptsetup package

FFe: Please merge cryptsetup 2:1.4.1-2 (main) from debian unstable (main)

Bug Description

Related branches

Other bug subscribers

Patches

Remote bug watches

Ubuntu
cryptsetup package