cryptroot-* autopkgtests fail on Ubuntu

[Benjamin Drung]

Running the autopkgtests from a merged cryptsetup 2:2.5.0-1 fails on Ubuntu 22.10 (kinetic):

autopkgtest [19:12:00]: @@@@@@@@@@@@@@@@@@@@ summary
upstream-testsuite PASS
ssh-test-plugin PASS
cryptdisks PASS
cryptdisks.init PASS
cryptroot-lvm FAIL non-zero exit status 100
cryptroot-legacy FAIL non-zero exit status 100
cryptroot-sysvinit FAIL non-zero exit status 100

The cryptroot-* autopkgtest call `setup_apt` which is tailored to Debian and fails on Ubuntu:

E: Unable to locate package apt

A full test log (run locally with a qemu autopkgtest runner) is attached.

[Brian Murray (brian-murray)]

Not only do they fail, they end up timing out which is a waste of resources so this should not be run anymore.

[Brian Murray (brian-murray)]

I've gone ahead and added the package to never_run for Jammy and Kinetic:

https://git.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-package-configs/commit/?id=fecfec0951e02ed7e59f42aa8ad996157784e42e

[Brian Murray (brian-murray)]

I've tagged this foundations-triage-discuss as I think fixing the autopkgtests should be a priority given that the package is in main.

[Vladimir Petko (vpa1977)]

Fixed common code and crypt-sysvinit test - branch available at https://code.launchpad.net/~vpa1977/+git/cryptsetup/+ref/vpa1977/lp1983522-enable-sysvinit-test and ppa at https://code.launchpad.net/~vpa1977/+archive/ubuntu/cryptsetup-fix

Looking into fixing initramfs-hook test, there is a difference in layout of initramfs that needs to be accounted for.

[Vladimir Petko (vpa1977)]

Need to fix blowfish test for initramfs-hook, rest are passing locally in a branch.
Should finish tomorrow.

[Vladimir Petko (vpa1977)]

We had to disable cryptdisks test due to it using tty device which is not present in CI environment.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cryptsetup - 2:2.5.0-6ubuntu2

---------------
cryptsetup (2:2.5.0-6ubuntu2) lunar; urgency=medium

  * Fix cryptroot-* autopkgtests on Ubuntu. (LP: #1983522)
    - debian/tests/utils/cryptroot-common: fix apt source and kernel package
      names for Ubuntu
    - debian/tests/cryptroot-sysvinit.d: use systemd-sysv init for Ubuntu
      cryptroot-sysvinit package test
    - debian/tests/cryptroot-nested.d: fix cryptsetup-nested test, add
      workaround for LP1831747 by adding a e2fsprogs dependency
    - debian/tests/control: disable cryptdisks, cryptroot-lvm due to CI
      failures and update comments
    - debian/tests/utils/mock.pm: fix cryptoroot-lvm test adding retries to the
      suspend operation and consuming the console buffer before making
      assertions. It still hangs in CI and requires further work.
    - debian/tests/initramfs-hook: fix test's initramfs layout for Ubuntu and
      allow blowfish test use 64Mb of provisioned space (drop --size)

 -- Vladimir Petko <email address hidden> Fri, 02 Dec 2022 14:14:42 +1300

[Michael Hudson-Doyle (mwhudson)]

Re-opening to track fix for cryptroot-lvm test.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cryptsetup - 2:2.5.0-6ubuntu3

---------------
cryptsetup (2:2.5.0-6ubuntu3) lunar; urgency=medium

  * Fix cryptroot-lvm autopkgtest on Ubuntu. (LP: #1983522)
    - debian/tests/control: enable cryptroot-lvm
    - debian/tests/utils/mock.pm: return from consume() function if select()
      times out or fails

 -- Vladimir Petko <email address hidden> Fri, 02 Dec 2022 15:53:42 +1300