FTBFS in bionic

[Eric Desrochers]

Debian commit [60fb7e6] in glibc first introduced in "debian/2.25-0experimental3-25-g60fb7e6", has the effect to create a FTBFS situation for "cross-toolchain-base" on Bionic which uses glibc 2.26.

In fact after the above commit, the patch "debian/patches/glibc/ubuntu/no-gdb-python-hooks.diff" found in cross-toolchain-base source code is no longer needed and can be safely remove as it tries to modify a piece of code already in place in glibc introduced by [60fb7e6], preventing the package to build with a hunk FAILED as follow :

# Launchpad buildlog : https://launchpadlibrarian.net/348143571/buildlog_ubuntu-bionic-amd64.cross-toolchain-base_19ubuntu1_BUILDING.txt.gz
...
Applying patch no-gdb-python-hooks.diff
patching file debian/rules.d/debhelper.mk
Hunk #1 FAILED at 220.
1 out of 1 hunk FAILED -- rejects in file debian/rules.d/debhelper.mk
Patch no-gdb-python-hooks.diff can be reverse-applied
debian/rules:382: recipe for target 'stamp-dir/init-glibc' failed
make: *** [stamp-dir/init-glibc] Error 1
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------
Build finished at 20171205-0736

**************************************************************************

# debian/patches/glibc/ubuntu/no-gdb-python-hooks.diff
--- a/debian/rules.d/debhelper.mk
+++ b/debian/rules.d/debhelper.mk
@@ -220,6 +220,7 @@
                -e "s#RTLDDIR#$$rtlddir#g" \
                -e "s#SLIBDIR#$$slibdir#g" \
                -e "s#LIBDIR#$$libdir#g" \
+ -e "/gdb/d" \
              $$t; \
          done ; \
        done

**************************************************************************

# debian/rules.d/debhelper.mk
220 -e "s#RTLDDIR#$$rtlddir#g" \
221 -e "s#SLIBDIR#$$slibdir#g" \
222 -e "s#LIBDIR#$$libdir#g" \
223 -e "/gdb/d" \
224 $$t; \
225 done ; \
226 done

[References & Other informations]

* Debian bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874491

* Debian commit:
https://anonscm.debian.org/cgit/pkg-glibc/glibc.git/commit/?id=60fb7e6

--------------------------------------------------------------------------
60fb7e6 debian/rules.d/debhelper.mk: do not install gdb python hooks for stage 1. Closes: #874491.

# git describe 60fb7e6
debian/2.25-0experimental3-25-g60fb7e6

# rmadison glibc
 glibc | 2.26-0ubuntu2 | bionic | source
--------------------------------------------------------------------------

* Debian Build logs:
https://buildd.debian.org/status/logs.php?pkg=cross-toolchain-base

* Ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1715366

* Launchpad Build logs:
https://launchpadlibrarian.net/348143571/buildlog_ubuntu-bionic-amd64.cross-toolchain-base_19ubuntu1_BUILDING.txt.gz

* Build status for Ubuntu Bionic
http://qa.ubuntuwire.org/ftbfs/

[Eric Desrochers (slashd)]

After removing the offending QUILT patch, it failed to build due to a missing "Build-Depends:" for dwz in debian/control.

But even after having fix 2 issues that I have notice, it still doesn't build properly.

I'll do my best to look at it deeper when I'll have some cycle. Otherwise, anybody please feel free to look at it as well.

- Eric

[Eric Desrochers (slashd)]

Sharing my work so far, in a debdiff format, if someone else want to continue/see at where I am.

- Eric

[Matthias Klose (doko)]

Eric, these issues are fixed in 22ubuntu1, however it still fails to build from source.

[Matthias Klose (doko)]

fixed in bionic now