Corewars should recommend nedit

[David Futcher]

Binary package hint: corewars

In order to edit a warrior in corewars using the built in edit button you must have nedit installed on the system. Corewars should suggest or recommend nedit when it is installed.

[Murat Gunes (mgunes)]

Thanks for your report. Marking as Triaged.

[James Westby (james-w)]

Hi,

I attached the Debian bug report on this issue.

That proposes an alternative solution, call
sensible-editor, however Michael wasn't too
keen on that, as it would give a useless terminal
window when launching an X editor.

Also consider that this game is based on gtk1,
and so without a port to gtk2 it's days may be
numbered in Debian. I'm not sure whether a
port is underway.

Thanks,

James

[Walter (moepot)]

I think '/usr/bin/editor' should be linked to a console-based editor. Because of this it's okay to start gnome-terminal and execute the default console-based editor.
But why not implement a tick in "editor settings" of corewars to mark the editor as console-based or not? Also set the default editor in corewars to an editor that is installed by default in ubuntu like nano or so.

Greets,
pot

[tisek (czechripper)]

Your whole discussion is true, but what you are talking about is improvement, while this would need, I believe, a fix, and then a thought about improvement.

[James Westby (james-w)]

Hi tisek,

You are correct. The Debian bug report is very old, so I will send a
message to it to see how Michael feels about it now.

One comment about your change, the version should be 0.9.13-1ubuntu1
instead of -1build2, so that your changes don't get overwritten by
the autosyncer.

Thanks,

James

[tisek (czechripper)]

Hi James.

Thanks for your help and feedback.
This is actually my very first contribution, so I am not yet fully familiar with the whole system. I did read a lot about it, but it still isn't completely natural.

I will make another patch, hoping to get it better.

Thanks.

[David Futcher (bobbo)]

After looking into this package a bit more I have discovered that it has been abandoned upstream since 2002, so a GTK2 port is unlikely to happen. Also, the last change (except for a gtk1.2 rebuild in the Hardy cycle) was back in 2002. Therefore it is very out of date (standards version 3.5.6). Considering this, maybe it would be a better idea to remove this package from the archives.

[tisek (czechripper)]

New debdiff, with a better version number.

[James Westby (james-w)]

Hi tisek,

You're change is almost there, but there's something I missed the first
time around.

Where you have put "Suggests" now it applies to the "Source" part of
the control file, however, it's not valid to have a suggests there, and
even if it was it probably wouldn't be what you wanted.

After the empty line is a "Binary" section, which correponds to the
package that is built and installed by users. This is where the "Suggests"
line needs to go, as that is the package that you want to declare
the relationship with nedit.

Thanks,

James

[tisek (czechripper)]

Thank you James for being that didactic :)

Should be fine now I believe.

[James Westby (james-w)]

Hello again tisek,

Your change looks good to me now, unfortunately though I'm not
a MOTU, so I can't upload it.

There is discussion over whether this change is correct or worth it,
but if it is not uploaded then I hope you will not take it as a personal
insult and instead go on to fix something else.

Thanks,

James

[tisek (czechripper)]

No problem.
No matter the outcome of that fix, I still learned on the process, and did what was supposed to be done given the bug description. I leave the discussion about the utility of the fix to the guys above ;).

tisek

[Daniel Holbach (dholbach)]

Do you think you could add "(LP: #197132)" to the debian/changelog entry?

[Daniel Holbach (dholbach)]

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

[Felipe Xavier (lipe-loko94)]

It was a long time ago since tisek posted his patch, so I did a patch for this bug :D

Felipe Xavier

[Felipe Xavier (lipe-loko94)]

Forget that patch, I did other patch that changes the default corewars' editor to editor instead of nedit ;D

Felipe Xavier

[Felipe Xavier (lipe-loko94)]

Sorry, I attached the file for intrepid, here is the debdiff for jaunty.

Felipe Xavier

[James Westby (james-w)]

Hi Felipe,

Thanks for looking at this.

The issue with doing the change to "editor" is that the editor is
probably set to a non-X-based editor, meaning that the user
wouldn't see the editor when they clicked the option.

Thanks,

James

[Daniel Holbach (dholbach)]

Sounds like an upstream problem. :-/

Also Felipe: try setting something like this in ~/.bashrc
export DEBFULLNAME='Daniel Holbach'
export <email address hidden>'

so your name and email address shows up in debian/changelog properly.

[Daniel Holbach (dholbach)]

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

[Miguel Ruiz (mruiz)]

Hi,

I'm working on it.

Cheers!

[Nigel Babu (nigelbabu)]

Please note that this package has been removed from Karmic and later releases.