[SRU] Update to containerd 1.3.1

[George Kraft]

[Impact]
Docker.io is a fast moving project, and SRU policy for containerd is that getting its .1 update out to LTS users quickly will bring more benefit than risks. This policy was approved by the tech board as of 2016-09-20.

[Test Case]
Checking autopkgtest is sufficient. See https://wiki.ubuntu.com/DockerUpdates for rationale

[Regression Potential]
See https://wiki.ubuntu.com/DockerUpdates for rationale.

[Fix]
1.3.1 is currently in focal-proposed. Any block-proposed tag should be removed to enable it to pass and land, then once migrated can be uploaded for SRU to requested series.

[Original Report]
Hey folks, we've got a Charmed Kubernetes bug[1] that requires us to run containerd 1.3.0+ to fix. Can we get the apt package in bionic universe updated to 1.3.1 or at least 1.3.0?

If possible, we would like to test the updated containerd package in bionic-proposed before it is released.

[1]: https://bugs.launchpad.net/charm-containerd/+bug/1853653

[Andreas Hasenack (ahasenack)]

Hello,

can you elaborate a bit more on what bug the update to 1.3.0 is fixing? It's usually better to cherry pick the exact fix needed instead of doing a somewhat big upgrade like this. Also, the 1.3.x series isn't even in ubuntu focal yet (1.3.1 is in focal-proposed).

[George Kraft (cynerva)]

We need support for TLS auth with image registries that was added in 1.3.0: https://github.com/containerd/cri/issues/1143

[Michael Hudson-Doyle (mwhudson)]

We've been backporting major revisions of docker.io/containerd/runc for the last few years. I think I would still argue this is more useful to end users than targeted cherry-picks.

[Bryce Harrington (bryce)]

Indeed, containerd appears to have an SRU special exception granted by tech board:

https://wiki.ubuntu.com/StableReleaseUpdates#Docker.io_group

"""
Docker.io group

The source packages docker.io, containerd, and runc may be uploaded according to the procedure documented in DockerUpdates. Per Technical Board discussion regarding delegation of these decisions to the SRU team, this stable release exception has been approved by BrianMurray for the SRU team as of 2016-09-20.
"""

The approved update policy that applies for this case is:

https://wiki.ubuntu.com/DockerUpdates

From this, Andreas is correct that 1.3.1 needs to be landed in devel first (perhaps it needs the block-proposed tag removed?) and complete migration, before 1.3.1 is uploaded for SRU to bionic.

[Bryce Harrington (bryce)]

Disco reached end of support, dropping its task from this bug.

[Michael Hudson-Doyle (mwhudson)]

So the status here is that containerd 1.3.1 is in focal-proposed but is stuck there because the docker autopkgtests are hanging:

http://autopkgtest.ubuntu.com/packages/d/docker.io/focal/amd64

I have no idea what is going on. It doesn't happen in my machine. I guess the next step is to get someone who has access to log into the machine after the test has hung and try to work out what is stuck.

[Launchpad Janitor (janitor)]

This bug was fixed in the package containerd - 1.3.2-0ubuntu1

---------------
containerd (1.3.2-0ubuntu1) focal; urgency=medium

  [ Tianon Gravi ]
  * Use "sed" to adjust upstream's service file ExecStart value
  * Update to 1.3.2 upstream release

  [ Michael Hudson-Doyle ]
  * d/patches/preserve-debug-info.patch: generate binaries with debug info in
    them so we still get ddebs.

 -- Michael Hudson-Doyle <email address hidden> Tue, 11 Feb 2020 12:29:51 +1300

[Brian Murray (brian-murray)]

Hello George, or anyone else affected,

Accepted containerd into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/containerd/1.3.3-0ubuntu1~19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello George, or anyone else affected,

Accepted containerd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/containerd/1.3.3-0ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted containerd (1.3.3-0ubuntu1~18.04.1) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

containerd/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#containerd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[George Kraft (cynerva)]

I've tested containerd 1.3.3 in bionic-proposed with Charmed Kubernetes 1.17 and everything looks good on our end. Our validation tests passed for both new deployments on containerd 1.3.3, and old deployments upgraded from containerd 1.2.6 to 1.3.3.

From my team's perspective, this is safe to release. Thanks!

[Michael Hudson-Doyle (mwhudson)]

Good enough for me.

[Launchpad Janitor (janitor)]

This bug was fixed in the package containerd - 1.3.3-0ubuntu1~19.10.1

---------------
containerd (1.3.3-0ubuntu1~19.10.1) eoan; urgency=medium

  * Backport to Eoan (LP: #1854841)

 -- Michael Hudson-Doyle <email address hidden> Mon, 17 Feb 2020 15:09:05 +1300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for containerd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package containerd - 1.3.3-0ubuntu1~18.04.1

---------------
containerd (1.3.3-0ubuntu1~18.04.1) bionic; urgency=medium

  * Backport to Bionic. (LP: #1854841)
  * Add Breaks: docker.io (<= 18.09.3~)

 -- Michael Hudson-Doyle <email address hidden> Mon, 17 Feb 2020 15:07:21 +1300