plymouth-start.service: After: reference to non-existent keyboard-setup.service

Bug #1579267 reported by TJ on 2016-05-06
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
console-setup (Ubuntu)
Medium
Mathieu Trudel-Lapierre
Xenial
Medium
Mathieu Trudel-Lapierre

Bug Description

[Impact]
Keymaps are not correctly set on virtual console (in gettys)

[Test case]
Set keymap, using us, intl variant. Test that dead keys behave correctly (ie. hitting an apostrophe and then e yields "é" rather than "'e".

[Regression potential]
System that carry a keyboard configuration but the system administrators rely on the fact that the local console keymap remains in US will find that it no longer behaves as expected.

---

16.04 amd64.

plymouth-start.service refers to a non-existent keyboard-setup.service:

$ grep keyboard -r /lib/systemd/system/*
/lib/systemd/system/plymouth-start.service:After=systemd-udev-trigger.service systemd-udevd.service keyboard-setup.service
tj@T300CHI:~$ apt-file search keyboard-setup.service
tj@T300CHI:~$

The file only exists in 16.10 in console-setup-linux

This caught me out whilst I was debugging some console-setup issues.

Steve Langasek (vorlon) wrote :

It's not a bug for a systemd unit to reference a non-existent unit in 'Before' or 'After'; this declares sequencing relative to other units *if* they exist. If the named unit does not exist, the relationship is ignored - this is not a 'Requires' dependency.

If anything, the bug here appears to be that the keyboard-setup.service is *absent* in 16.04. Reassigning to console-setup for investigation.

affects: plymouth (Ubuntu) → console-setup (Ubuntu)
Changed in console-setup (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)

Nice catch.

There is a keyboard-setup.init script; but that's not being installed either because for upstart, all these were replaced by a single upstart job to deal with the keyboards.

The net result appears to be that keymap is not correctly set in a VT -- I'll look to find other reports of this issue, there is bound to be others.

There is another fix I need to land for console-setup related to the move from upstart to systemd; we can land all this together.

Changed in console-setup (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
Changed in console-setup (Ubuntu Xenial):
status: New → In Progress
importance: Undecided → Medium
Changed in console-setup (Ubuntu):
status: In Progress → Fix Released
Changed in console-setup (Ubuntu Xenial):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
description: updated

Hello TJ, or anyone else affected,

Accepted console-setup into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/console-setup/1.108ubuntu15.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in console-setup (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Sebastien Bacher (seb128) wrote :

bug #1591622 seems a regression from that sru, setting as verification failed to avoid having it copied to updates by error before having the other bug investigated

tags: added: verification-failed
removed: verification-needed
Martin Pitt (pitti) wrote :

Hello TJ, or anyone else affected,

Accepted console-setup into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/console-setup/1.108ubuntu15.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-failed
tags: added: verification-needed
Dimitri John Ledkov (xnox) wrote :

keyboard-setup.service now exist and there are no depedency cycles in plymouth-start and all is good.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package console-setup - 1.108ubuntu15.2

---------------
console-setup (1.108ubuntu15.2) xenial; urgency=medium

  * Reorganize and correct console-setup, keyboard-setup and setvtrgb along the
    lines of the logic in 16.04: (LP: #1591622, #1593156)
    - debian/console-setup-linux.setvtrgb.service: don't require being run
      before system-getty.slice.
    - debian/keyboard-configuration.links: both console-setup and
      keyboard-setup systemd units should be installed to sysinit.target rather
      than multi-user.
    - debian/keyboard-configuration.keyboard-setup.service: move loadkeys call
      at local-fs-pre.target and in this more suitable location.
    - debian/keyboard-configuration.console-setup.service: move to running
      after the screen, keyboard, and filesystems are ready and set up all of
      what may still need to be done to configure the virtual consoles
      appropriately: set a final keymap, font, etc.

console-setup (1.108ubuntu15.1) xenial; urgency=medium

  * debian/console-setup-linux.setvtrgb.service: port the upstart job for
    applying our preferred color settings to a systemd unit so it gets run.
    This will fix debconf prompts on console being extra ugly. (LP: #1576893)
  * debian/console-setup-linux.links: enable our setvtrgb service in sysinit.
  * debian/keyboard-configuration.links: fix link source for console-setup
    service. (LP: #1572697)
  * debian/control: add dh-systemd to Build-Depends.
  * debian/keyboard-configuration.keyboard-setup.service: also enable
    keyboard-setup as a systemd service so we can have proper keymaps enabled
    in VTs. (LP: #1579267)
  * debian/keyboard-configuration.links: enable keyboard-setup service.

 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 16 Jun 2016 14:41:19 +0300

Changed in console-setup (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for console-setup has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers