conky top_mem works wrong

[lolikandr]

Binary package hint: conky

Following text in .conkyrc works wrong:
${top_mem mem_res 1}
Problem solved by change some strings in conky.c. Below conky.c.diff:
5982c5982
< human_readable(cur->memu[obj->data.top.num]->rss,
---
> human_readable(cur->cpu[obj->data.top.num]->rss,
5986c5986
< human_readable(cur->memu[obj->data.top.num]->vsize,
---
> human_readable(cur->cpu[obj->data.top.num]->vsize,

[Launchpad Janitor (janitor)]

This bug was fixed in the package conky - 1.6.1-0ubuntu4

---------------
conky (1.6.1-0ubuntu4) jaunty; urgency=low

  * debian/patches:
    - fix_mem_res.patch (LP: #329789):
      fix ${top_mem} not displaying correctly memory usage
      for mem_res and mem_vsize.
      Thanks to lolikandr for the patch.

 -- Cesare Tirabassi <email address hidden> Mon, 16 Feb 2009 13:12:00 +0100

[brenden (brenden)]

The top stuff has been refactored recently, could someone please try it from git? The url is git://git.omp.am/conky.git

Thanks.

[Cesare Tirabassi (norsetto)]

@Brenden,

I can confirm that current git (Tue Feb 17 22:50:43 2009 -0700) solves the problem.

As an additional note (see http://sourceforge.net/tracker/index.php?func=detail&aid=2213934&group_id=143975&atid=757308) related to this problem, in 1.6.1 (and current git) error messages related to top_mem are reported to be from top, for instance if I omit the 1 in ${top_mem mem_res 1} I get the following error message:

Conky: invalid argument count for top

I don't know if thats the way you meant it to be?

[Cesare Tirabassi (norsetto)]

>I don't know if thats the way you meant it to be?

Which looking at your code seems to be the case.

[brenden (brenden)]

> I don't know if thats the way you meant it to be?

I believe that is the way it is meant to be.

[Cesare Tirabassi (norsetto)]

Amen.