| 2017-10-20 03:54:16 |
Geoffrey Thomas |
bug |
|
|
added bug |
| 2017-10-20 04:14:41 |
Geoffrey Thomas |
attachment added |
|
config-package-dev_5.2ubuntu0.1.debdiff https://bugs.launchpad.net/ubuntu/+source/config-package-dev/+bug/1725110/+attachment/4977653/+files/config-package-dev_5.2ubuntu0.1.debdiff |
|
| 2017-10-20 04:16:53 |
Geoffrey Thomas |
attachment added |
|
config-package-dev_5.4-ubuntu17.10.1.debdiff https://bugs.launchpad.net/ubuntu/+source/config-package-dev/+bug/1725110/+attachment/4977654/+files/config-package-dev_5.4-ubuntu17.10.1.debdiff |
|
| 2017-10-20 04:19:28 |
Geoffrey Thomas |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2017-10-20 05:47:56 |
Launchpad Janitor |
config-package-dev (Ubuntu): status |
New |
Confirmed |
|
| 2017-10-20 16:27:00 |
Brian Murray |
nominated for series |
|
Ubuntu Artful |
|
| 2017-10-20 16:27:00 |
Brian Murray |
bug task added |
|
config-package-dev (Ubuntu Artful) |
|
| 2017-10-27 19:15:03 |
Geoffrey Thomas |
description |
[Impact]
As reported at https://bugs.debian.org/873966 , a patch in config-package-dev 5.2 broke the transform functionality entirely. Any attempt to use transforms in a config package causes the build to fail with
Can't use string ("/ARRAY(0x7fda137152e0)") as an ARRAY ref while "strict refs" in use at /usr/bin/dh_configpackage line 394.
config-package-dev is a tool used as a build-dependency in private (third-party) Debian packages, so this causes those packages to FTBFS in artful when they built successfully in older releases.
Bruno Maitre reported the problem and provided a patch to fix the bug, which has been incorporated into version 5.3 in Debian.
[Test Case]
config-package-dev ships one example that uses the transform functionality, but the version in 5.2 doesn't quite build right in artful (or in Debian unstable). So the easiest way is to grab the updated example from git:
apt install config-package-dev debhelper lynx
wget http://github.com/sipb/config-package-dev/archive/master.tar.gz
tar xf master.tar.gz
cd config-package-dev-master/examples/debhelper/debathena-transform-example-1.0
dpkg-buildpackage
With config-package-dev 5.2, this will FTBFS at the "dh_configpackage" step; with the fixed version, the package will build. (If you're curious you can try dpkg -i'ing the resulting package, which will change lynx's home page to default to web.mit.edu.)
[Regression Potential]
I'm attaching two debdiffs to this bug. One backports version 5.4 from Debian unstable, which in addition to fixing this bug, fixes the examples to build on unstable, adds an autopkgtest to make sure the examples build, and makes no other code changes. The other just cherry-picks the one change.
Arguably the regression potential for the autopkgtest version is less, since if tests pass that gives us confidence that the new version works on Ubuntu. (I have been doing my testing on Ubuntu.) I'd prefer this version, under the rules for SRUing an upstream microrelease of a package with a test suite. But it does change more; if you prefer the targeted fix that's fine with me too.
The regression potential compared to 5.2 is extremely low, since 5.2 is definitely broken for packages that use transforms, and Bruno's patch only affects the code that handles transforms. I am also confident in the patch now that I have added autopkgtests and they pass on Debian unstable, stretch, and jessie (thanks, travis.debian.net!).
Also, as noted the previous time we SRU'd config-package-dev (LP #899732), nothing in the Ubuntu or Debian archive build-depends on config-package-dev; it's a tool used by external packages. So even if there is a regression it will be low-severity. |
[Impact]
As reported at https://bugs.debian.org/873966 , a patch in config-package-dev 5.2 broke the transform functionality entirely. Any attempt to use transforms in a config package causes the build to fail with
Can't use string ("/ARRAY(0x7fda137152e0)") as an ARRAY ref while "strict refs" in use at /usr/bin/dh_configpackage line 394.
config-package-dev is a tool used as a build-dependency in private (third-party) Debian packages, so this causes those packages to FTBFS in artful when they built successfully in older releases.
Bruno Maitre reported the problem and provided a patch to fix the bug, which has been incorporated into version 5.3 in Debian.
[Test Case]
config-package-dev ships one example that uses the transform functionality, but the version in 5.2 doesn't quite build right in artful (or in Debian unstable). So the easiest way is to grab the updated example from git:
apt install config-package-dev debhelper lynx
wget http://github.com/sipb/config-package-dev/archive/master.tar.gz
tar xf master.tar.gz
cd config-package-dev-master/examples/debhelper/debathena-transform-example-1.0
dpkg-buildpackage
With config-package-dev 5.2, this will FTBFS at the "dh_configpackage" step; with the fixed version, the package will build. (If you're curious you can try dpkg -i'ing the resulting package, which will change lynx's home page to default to web.mit.edu.)
[Regression Potential]
I'm attaching two debdiffs to this bug. One backports version 5.4 from Debian unstable, which in addition to fixing this bug, fixes the examples to build on unstable, adds an autopkgtest to make sure the examples build, and makes no other code changes. The other just cherry-picks the one change.
Arguably the regression potential for the autopkgtest version is less, since if tests pass that gives us confidence that the new version works on Ubuntu. (I have been doing my testing on Debian.) I'd prefer this version, under the rules for SRUing an upstream microrelease of a package with a test suite. But it does change more; if you prefer the targeted fix that's fine with me too.
The regression potential compared to 5.2 is extremely low, since 5.2 is definitely broken for packages that use transforms, and Bruno's patch only affects the code that handles transforms. I am also confident in the patch now that I have added autopkgtests and they pass on Debian unstable, stretch, and jessie (thanks, travis.debian.net!).
Also, as noted the previous time we SRU'd config-package-dev (LP #899732), nothing in the Ubuntu or Debian archive build-depends on config-package-dev; it's a tool used by external packages. So even if there is a regression it will be low-severity. |
|
| 2017-10-27 19:43:36 |
Geoffrey Thomas |
attachment added |
|
config-package-dev_5.4~ubuntu17.10.1.debdiff https://bugs.launchpad.net/ubuntu/+source/config-package-dev/+bug/1725110/+attachment/4998223/+files/config-package-dev_5.4~ubuntu17.10.1.debdiff |
|
| 2017-10-27 19:56:36 |
Nish Aravamudan |
config-package-dev (Ubuntu): status |
Confirmed |
Fix Committed |
|
| 2017-10-27 19:56:44 |
Nish Aravamudan |
bug |
|
|
added subscriber Nish Aravamudan |
| 2017-11-06 18:48:57 |
Nish Aravamudan |
config-package-dev (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2017-11-06 18:49:00 |
Nish Aravamudan |
config-package-dev (Ubuntu Artful): status |
Confirmed |
In Progress |
|
| 2017-11-06 18:49:02 |
Nish Aravamudan |
config-package-dev (Ubuntu Artful): assignee |
|
Nish Aravamudan (nacc) |
|
| 2017-11-06 22:57:50 |
Nish Aravamudan |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2017-11-06 22:58:19 |
Nish Aravamudan |
config-package-dev (Ubuntu Artful): status |
In Progress |
Fix Committed |
|
| 2017-11-06 22:58:34 |
Nish Aravamudan |
config-package-dev (Ubuntu Artful): assignee |
Nish Aravamudan (nacc) |
|
|
| 2017-11-09 18:08:18 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-11-09 18:08:21 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2017-11-09 18:08:27 |
Brian Murray |
tags |
|
verification-needed verification-needed-artful |
|
| 2017-11-09 22:39:22 |
Geoffrey Thomas |
tags |
verification-needed verification-needed-artful |
verification-done-artful verification-needed |
|
| 2017-11-20 18:06:41 |
Launchpad Janitor |
config-package-dev (Ubuntu Artful): status |
Fix Committed |
Fix Released |
|
| 2017-11-20 18:06:45 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
