I do not want to remove '/'

Bug #337241 reported by Ted Gould on 2009-03-03
Affects Status Importance Assigned to Milestone
computer-janitor (Ubuntu)

Bug Description

Binary package hint: computer-janitor

In computer-janitor there are two rows of items. A "remove" checkbox and a description. This is a bad name as some of the items are not removing at all, but are instead "Do" or "Execute" type actions. Either fixing files or other types of system level improvements. These should not be labeled with "Remove". See screenshot for how a user could "Remove /"

Ted Gould (ted) wrote :
Chris Coulson (chrisccoulson) wrote :

That is really confusing. I looked at your screenshot before reading the bug description and my first thought was "why on earth does this want to delete the root filesystem?"

Changed in computer-janitor:
importance: Undecided → Low
status: New → Triaged
Matthew Paul Thomas (mpt) wrote :

The columns could be labelled "Approve" and "Cleanup". That would require the items that actually are going to delete a file to begin with the word "Remove" (e.g. "Remove obsolete /etc/apt/apt.conf.d/10periodic-dpkg.old"), to distinguish them from the non-deleting items (e.g. "Set /home to update file access times less often").

to be removed (liw) wrote :

The column title is now "Remove/fix?", which should be clear.

Changed in computer-janitor:
status: Triaged → Fix Released

On Mon, 2009-03-30 at 13:56 +0000, Lars Wirzenius wrote:
> The column title is now "Remove/fix?", which should be clear.

No, it's really not. There is no way for me to tell which one is really
a remove and which one is really a fix. I think that MPT's suggestion
of changing the column to "Approve" and then let the text of the action
describe what should be happening would fix the problem more elegantly
and would result in less user confusion.

   status confirmed

Changed in computer-janitor:
status: Fix Released → Confirmed


What about 'Apply Changes?' for the column title?
If the description at each row explains the change (a delete, a modification of a file on the disk, a missing mount option or whatever) I think there won't be a confusion.

Ian (ian-dalton) wrote :

I think the interface is just wrong for what you're trying to do. You should have separate sections for different actions. Something like the interface used for System>Preferences>Keyboard>Layouts>Layout Options would be ideal. System>Preferences>Keyboard Shortcuts is alright too, but I'd like to be able to select an item to see a detailed description without toggling whether its box is checked.

to be removed (liw) wrote :

I've commited a new UI, see my PPA (https://launchpad.net/~liw/+archive/ppa) for packages for karmic. This should take care of the problem.

Changed in computer-janitor (Ubuntu):
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package computer-janitor - 1.13.2-0ubuntu1

computer-janitor (1.13.2-0ubuntu1) karmic; urgency=low

  * New upstream version. Closes bugs in Launchpad:
    - System cleaner removes explicitly installed third-party packages
      (LP: #285746)
    - I do not want to remove '/' (LP: #337241)
    - computer-janitor incomplete error description (LP: #365325)
    - computer-janitor commandline interface not pipe-friendly (LP: #375094)
    - Python 2.6 DeprecationWarning: Accessed deprecated property
      Package.candidateDownloadable (LP: #407127)
    - Should use GtkBuilder rather than libglade (LP: #403537)
    - Ambiguous wording in confirmation alert box (LP: #349336)
    - computer-janitor-gtk crashed with UnicodeDecodeError in
      get_description() (LP: #352461)
    - Can't deselect fixes with space in computer-janitor (LP: #355535)
    - relatime tweak will not be necessary in karmic (LP: #369151)
    - computer janitor needs filesize column (LP: #396522)
  * Packaging now uses dh from debhelper 7.

 -- Lars Wirzenius <email address hidden> Fri, 21 Aug 2009 15:48:12 +0300

Changed in computer-janitor (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers