Drop-down menus look disembodied from their titles

Bug #659816 reported by Matthew Paul Thomas on 2010-10-13
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Compiz Core
High
Sam Spilsbury
compiz (Ubuntu)
Low
Sam Spilsbury
Natty
Low
Jason Smith

Bug Description

Binary package hint: light-themes

Menus are drawn as if they are a separate layer above (closer to you than) their titles. This is unattractive in two ways. First, it inevitably makes the menus look as if they are not lined up horizontally with their titles, when they are. Second, it makes menus look harder to use, because you need to "climb on" to them after opening them.

This could be fixed in two steps:
* Remove the shadow from the top edge of menus, applying a shadow only to the three other edges.
* Use the standard menu selection color for menu titles, rather than an inconsistent outline.

Problem occurs with: light-themes 0.1.8.2, Ubuntu 10.10
Does not occur with: Mac OS X 10.6, Windows 7

[Originally reported by Ersin Akinci in <https://lists.ubuntu.com/archives/ubuntu-art/2010-October/012364.html>, points #5, #6, and #7.]

Related branches

Matthew Paul Thomas (mpt) wrote :
Jason Smith (jassmith) wrote :

This bug will need to be fixed in compiz (as an option). Chop shadow tops. There is something to be said for having the shadow show again if the window it is modal for is not under that part of the window. I will discuss with sam and come up with a solution for compiz.

affects: light-themes (Ubuntu) → compiz (Ubuntu)
Changed in compiz (Ubuntu):
assignee: nobody → Jason Smith (jassmith)
status: New → Incomplete
Jason Smith (jassmith) on 2011-01-10
Changed in compiz (Ubuntu):
status: Incomplete → In Progress
David Barth (dbarth) wrote :

Jason: pass that on to Cimi when there is something to fix at the theme level.

Changed in compiz (Ubuntu):
milestone: none → natty-alpha-2
importance: Undecided → Low
Martin Pitt (pitti) on 2011-02-04
Changed in compiz (Ubuntu Natty):
milestone: natty-alpha-2 → natty-alpha-3
Martin Pitt (pitti) on 2011-03-02
Changed in compiz (Ubuntu Natty):
milestone: natty-alpha-3 → ubuntu-11.04-beta-1
Changed in compiz (Ubuntu Natty):
milestone: ubuntu-11.04-beta-1 → ubuntu-11.04-beta-2
Sam Spilsbury (smspillaz) wrote :

Fix for this was released ages ago. closing.

Changed in compiz (Ubuntu Natty):
status: In Progress → Fix Released
Matthew Paul Thomas (mpt) wrote :

Reproduced with a new user account in Ubuntu Natty with all updates installed, including compiz 1:0.9.4+bzr20110415-0ubuntu2 and light-themes 0.1.8.13. I don't see any difference at all.

Changed in compiz (Ubuntu Natty):
milestone: ubuntu-11.04-beta-2 → none
status: Fix Released → New
Matthew Paul Thomas (mpt) wrote :
Matthew Paul Thomas (mpt) wrote :

Actually, there's a slight difference in that the menu is now 1px to the right of where it was, making it line up better. But the shadow seems just as bad as before.

Chris S (cgseif323) on 2011-06-27
Changed in compiz (Ubuntu Natty):
status: New → Confirmed
Andrea Cimitan (cimi) on 2012-01-11
Changed in compiz-core:
assignee: nobody → Sam Spilsbury (smspillaz)
Andrea Cimitan (cimi) wrote :

Definitely important for LIM

Changed in compiz-core:
milestone: none → 0.9.7.2
importance: Undecided → High
Changed in compiz-core:
milestone: 0.9.7.2 → 0.9.7.4
Changed in compiz-core:
milestone: 0.9.7.4 → none
Changed in compiz-core:
milestone: none → 0.9.7.6
Changed in compiz-core:
status: New → Fix Committed
Daniel van Vugt (vanvugt) wrote :

Cool. But fix committed where?

Changed in compiz-core:
status: Fix Committed → Fix Released
Andrea Cimitan (cimi) wrote :

Does not work perfectly here, on the desktop the shadow is not casted, and when you switch between menuitems in the panel you see the shadow appearing on top and then being cut. Shall we revert?

Daniel van Vugt (vanvugt) wrote :

Cimi, I'm not sure there was any fix committed in the first place. Unless Sam thinks r3086 of lp:compiz-core should fix this bug?...

Andrea Cimitan (cimi) wrote :

Yep in the code there are matches for menus as well, but they seem to cause issues there and there. If the shadow clipping is done with a redraw as it is now, it's better not to clip at all.

This bug can be considered fixed when it behaves cleanly like mutter... at this moment, IMHO, it's better to revert or to remove the window class match.

Daniel van Vugt (vanvugt) wrote :

Confirmed that this bug is only partially fixed and still occurs about 30% of the time. Also, there seems to be a regression with 0.9.7.6 where panel menus get no shadows at all half the time.

Changed in compiz-core:
status: Fix Released → Triaged
milestone: 0.9.7.6 → none
Daniel van Vugt (vanvugt) wrote :

Cimi, I have logged the regression as bug 977718.

Daniel van Vugt (vanvugt) wrote :

In theory this bug could easily be fixed by redrawing the menu title part in the panel after the menu itself has rendered. At the moment, the unity panel draws the title early so as to improve visual responsiveness. I remember because I wrote the code.

Andrea Cimitan (cimi) wrote :

I changed the inactive shadow color to be red, so the bug is more visible :)

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.7.6-0ubuntu1

---------------
compiz (1:0.9.7.6-0ubuntu1) precise; urgency=low

  [ Didier Roche ]
  * New upstream release:
    - Memory leak in dlloaderListPlugins (LP: #968985)
    - priv->invisible is not updated when the window is mapped (LP: #969102)
    - window management, multi-monitor - In multi-monitor environment, windows
      should spread on the monitor in which they reside (LP: #919139)
    - Drop-down menus look disembodied from their titles (LP: #659816)
    - Improve performace of the shadow clipping code (LP: #931883)
    - DecorWindow::computeShadowRegion called way too much (LP: #969101)
    - white box randomly shows up at top left corner blocking application
      from using stuff under it (LP: #940603)
  * Rebuild against latest metacity to get the HUD key configuration
    exposed in unity 3D as well (LP: #969256)
  * debian/patches/ubuntu-config.patch:
    - set multioutput_mode to all outputs (windows to be scaled on each the
      monitor they are on only) (LP: #919139)
  * debian/patches/fix_976467.patch:
    - Fix shadows being clipped incorrectly (LP: #976467)

  [ Oliver Grawert ]
  * update the GLES2 patch for the new upstream release.
 -- Didier Roche <email address hidden> Wed, 11 Apr 2012 18:35:39 +0200

Changed in compiz (Ubuntu):
status: New → Fix Released
Daniel van Vugt (vanvugt) wrote :

This bug was never fixed. It was release noted by accident.

Changed in compiz (Ubuntu):
status: Fix Released → Triaged
assignee: Jason Smith (jassmith) → Sam Spilsbury (smspillaz)

On Thu, 12 Apr 2012, Daniel van Vugt wrote:

> This bug was never fixed. It was release noted by accident.
>

I believe it was referring to the indicators and global menu case. In
those cases, it is indeed, fixed.

Its not possible to fix this bug for the old style non global menus. LIM
is another story, but definitely fixable.

This is why the fix was release noted. If you think it isn't fixed, then
please explain why.

> ** Changed in: compiz (Ubuntu)
> Status: Fix Released => Triaged
>
> ** Changed in: compiz (Ubuntu)
> Assignee: Jason Smith (jassmith) => Sam Spilsbury (smspillaz)
>
> --
> You received this bug notification because you are a member of compiz
> packagers, which is subscribed to compiz in Ubuntu.
> https://bugs.launchpad.net/bugs/659816
>
> Title:
> Drop-down menus look disembodied from their titles
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/compiz-core/+bug/659816/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~compiz
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~compiz
> More help : https://help.launchpad.net/ListHelp
>

Daniel van Vugt (vanvugt) wrote :

Wow, OK. Every time I compiled and tested the latest shadowing fixes, they never worked for me on precise. But now I'm running them from the PPA, it works.

I'm happy to be wrong. Bug fixed in 0.9.7.6.

Changed in compiz-core:
milestone: none → 0.9.7.6
status: Triaged → Fix Released
Changed in compiz (Ubuntu):
status: Triaged → Fix Released
Adolfo Jayme (fitojb) on 2013-12-10
Changed in compiz (Ubuntu Natty):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers